MP OpenAPI 3.1 support for 4.x #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged with the artifact
…ex from Hibernate ORM
…on test create jandex earlier so it will be in the test jar
… references from hand-crafted TOC
tjquinno
requested review from
romain-grecourt,
spericas,
barchetta,
tomas-langer and
arjav-desai
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
reviewed
Jun 13, 2023
.../quickstarts/helidon-quickstart-se/src/main/java/io/helidon/examples/quickstart/se/Main.java
Show resolved
Hide resolved
microprofile/lra/jax-rs/src/main/java/io/helidon/microprofile/lra/LraCdiExtension.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MpOpenApiFeature.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/OpenApiParser.java
Outdated
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/Serializer.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
archetypes/helidon/src/main/archetype/mp/oci/files/pom.xml.mustache
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
...rations/neo4j/neo4j-mp/src/test/java/io/helidon/examples/integrations/neo4j/mp/MainTest.java
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Jun 13, 2023
ljnelson
reviewed
Jun 13, 2023
microprofile/lra/jax-rs/src/main/java/io/helidon/microprofile/lra/LraCdiExtension.java
Show resolved
Hide resolved
...openapi/src/main/java/io/helidon/microprofile/openapi/HelidonAnnotationScannerExtension.java
Outdated
Show resolved
Hide resolved
...openapi/src/main/java/io/helidon/microprofile/openapi/HelidonAnnotationScannerExtension.java
Outdated
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MPOpenAPIBuilder.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MPOpenAPIBuilder.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MPOpenAPIBuilder.java.save
Outdated
Show resolved
Hide resolved
ljnelson
reviewed
Jun 13, 2023
| } | ||
|
|
||
| // See if we should parse the value fully. | ||
| switch (value.charAt(0)) { |
There was a problem hiding this comment.
(Minor; could do return switch ...)
ljnelson
reviewed
Jun 13, 2023
| * @throws IOException in case of I/O problems | ||
| */ | ||
| static OpenAPI parse(Map<Class<?>, ExpandedTypeDescription> types, InputStream inputStream) throws IOException { | ||
| try (Reader reader = new InputStreamReader(inputStream, StandardCharsets.UTF_8)) { |
There was a problem hiding this comment.
OK to not have a BufferedReader?
trentjeff
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5820
This PR adds MP OpenAPI 3.1 support to 4.x.
Do not be overly alarmed by the number of changed files! Read below.
Some details:
org.jbosstoio.smallryefor its GAV coordinates while keeping theorg.jboss.jandexpackages. This PR adopts the newio.smallryeJandex artifacts (code and maven plug-in). There are related changes in manypom.xml(inflating the changed-file count) and a few other files.nima/openapiand provides only limited and very simple support for a static OpenAPI document file. This will change in a later PR focused on SE OpenAPI support.)openapimodule.org.hibernate.orm:hibernate-ormwhich depends on Weld which in turn depends on Jandex. The ORM module pulled in the older release of Jandex, so in our Hibernate CDI component this PR adds an exclusion oforg.jboss:jandexso it also uses the newerio.smallryepackaging. Fortunately, it seems the ORM code does not use now-removed APIs in Jandex.