Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for declarative exclusion of Telemetry spans being generated from HelidonTelemetryClientFilter #9550

Closed
jvissers opened this issue Dec 3, 2024 · 1 comment · Fixed by #9552
Assignees
Labels
4.x Version 4.x enhancement New feature or request MP telemetry
Milestone

Comments

@jvissers
Copy link

jvissers commented Dec 3, 2024

Environment Details

  • Helidon Version: 4.1.4
  • Helidon MP
  • OpenJDK 64-Bit Server VM (build 23+37-2369, mixed mode, sharing)
  • OS: Ubuntu 24.04.1 LTS

Feature Request

We have a number of Microprofile Healthchecks, that of which leverage the REST client to check prerequisites for OCI ObjectStorage access. Because of the HelidonTelemetryClientFilter this now generates spans that are unwanted, and result in a considerable amount of noise. We are raising this feature request to ask for a mechanism that allows us to declaratively specify some exclusion(s) criteria that avoids creating these unwanted spans.

Workaround

The workaround suggested, in our case where we use OTEL, is to create a custom SpanProcessor that would then pick up information from a (Helidon) context to shortcircuit the span. From the calling code (i.e., a Health check component) the idea would be then to set up that piece of information and make it available through runInContext, for the custom SpanProcessor to use.

@github-project-automation github-project-automation bot moved this to Triage in Backlog Dec 3, 2024
@tjquinno tjquinno moved this from Triage to Sprint Scope in Backlog Dec 3, 2024
@tjquinno tjquinno added this to the 4.1.5 milestone Dec 3, 2024
@tjquinno tjquinno self-assigned this Dec 3, 2024
@tjquinno tjquinno added enhancement New feature or request MP 4.x Version 4.x telemetry labels Dec 3, 2024
@jvissers
Copy link
Author

jvissers commented Dec 3, 2024

For completeness; the suggested workaround doesn't actually stop the noisy traces. That is something that currently we simply cannot control, as the trace/span is created from within the HelidonTelemetryClientFilter. So ultimately we should consider rewording this issue, to indicate that really we want to avoid noisy traces from ending up being emitted.

@github-project-automation github-project-automation bot moved this from Sprint Scope to Closed in Backlog Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x enhancement New feature or request MP telemetry
Projects
Archived in project
2 participants