3.x Helidon OpenAPITools server generator seems to ignore requestBody/required

[tjquinno]

Environment Details

• Helidon Version: 3.x
• Helidon SE or Helidon MP
• JDK version:
• OS:
• Docker version (if applicable):

---

Problem Description

The OpenAPITools generator seems to ignore the requestBody/required setting.

There might be a problem with the generator framework rather than with the Helidon generator(s). See OpenAPITools/openapi-generator#16561

This issue represents that we need to:

• verify whether there needs to be a Helidon-specific fix for this, and
• if not, track the openAPITools issue.

Steps to reproduce

1. Download the greeting.yml.txt file attached to this issue and remove the .txt suffix. It is an OpenAPI document for the Helidon greeting app with the PUT operation's requestBody set to required: false.
2. Download the generator following these instructions. Remember where you downloaded the generator.
3. Run the generator:

java -jar ${path-to-generator}/openapi-generator-cli.jar \
  generate \
  -i greeting.yml \
  -g java-helidon-server \
  --library se \
  -p groupId=io.helidon.examples \
  -p artifactId=helidon-openapigen-se-server \
  -p artifactVersion=1.0.0-SNAPSHOT \
  -p apiPackage=io.helidon.examples.openapigen.se.server.api \
  -p modelPackage=io.helidon.examples.openapigen.se.server.model \
  -p invokerPackage=io.helidon.examples.openapigen.se.server

4. The generated code returns 501 - not implemented for the endpoints (because after generator the developer typically customizes the code to implement the business logic), but we can reproduce the problem without revising the generated code.
   1. Build and run the generated project.

   mvn clean package
   java -jar target/helidon-openapigen-se-server.jar
   

   2. In another terminal window, run curl -v -X PUT -d "{ \"message\": \"Hola\" }" http://localhost:8080/greet/greeting which returns 501, also expected. This verifies that the generated server endpoint is invoked--that's what returns the 501.
   3. Same window, run curl -v -X PUT http://localhost:8080/greet/greeting. This does not set the request body which, according to the OpenAPI document, should not be required. The response is 500 - internal server error. The generated endpoint is not reached.
5. Back in the original terminal window, you'll see exceptions because JacksonBodyReader is trying to process the missing content as it prepares to invoke the generated server endpoint.

greeting.yml.txt

[Captain1653]

Looks like it's bug of the generator. There is some workaround in this comment .

Is it still should be checked?