check-encryption-leaks: small change in formatting prints

This commit adjusts the formatting in our prints. In particular:
* Inner IPv4/IPv6 packet: let's print protocol before length, to align to
  the outer packet print. This will still print also all the supplementary
  info, such as ifindex, netns, etc. We leave these info there given the
  inner packet is always reported, both in Native and Overlay mode.
* L4 info: the whole `Detected TCP message, TCPFlags: ...` can be further
  simplified to just `TCP (TCPFlags: ...)`. The same applies to UDP and ICMP.
  This makes the print more compact and easier to read.
* ICMP: let's print Type and Code before the other fields, given they are
  the most relevant ones and immediately refer to the ICMP message type.

Example of an ICMP packet via VXLAN:

```
[10:49:50:268834] [0xffff8907af02e100] 172.18.0.3:36366 -> 172.18.0.4:8472 (proto: 17, encap: 1, skb: 0)
[10:49:50:268834] [0xffff8907af02e100]  ↳ 10.244.2.11:0 -> 10.244.0.43:0 (proto: 1, len: 84, ifindex: 7, netns: f0000000, srcPod: 1 (internal: 0), dstPod: 1 (internal: 0), proxy: 0 (masqueraded: 0))
[10:49:50:268834] [0xffff8907af02e100]   ↳ ICMP (Type: 8, Code: 0, IPFlags: .D., FragOff: 0, FragID: 54072)
```

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>

Author: smagnani96

.github/actions/bpftrace/scripts/check-encryption-leaks.bt

@@ -160,14 +160,14 @@ kprobe:br_forward
             $encap, $skb->encapsulation);
         }
 
-        printf("[%s] [%p]  ↳ %s:%d -> %s:%d (len: %d, proto: %d, ifindex: %d, netns: %x, srcPod: %d (internal: %d), dstPod: %d (internal: %d), proxy: %d (masqueraded: %d))\n",
+        printf("[%s] [%p]  ↳ %s:%d -> %s:%d (proto: %d, len: %d, ifindex: %d, netns: %x, srcPod: %d (internal: %d), dstPod: %d (internal: %d), proxy: %d (masqueraded: %d))\n",
           $time, $skb,
           ntop($ip4h->saddr),
           ($ip4h->protocol == PROTO_UDP || $ip4h->protocol == PROTO_TCP) ? bswap($udph->source) : 0,
           ntop($ip4h->daddr),
           ($ip4h->protocol == PROTO_UDP || $ip4h->protocol == PROTO_TCP) ? bswap($udph->dest) : 0,
-          bswap($ip4h->tot_len),
           $ip4h->protocol,
+          bswap($ip4h->tot_len),
           $skb->dev->ifindex,
           $skb->dev->nd_net.net->ns.inum,
           $src_is_pod, $src_is_internal,
@@ -176,7 +176,7 @@ kprobe:br_forward
           $pod_to_pod_via_proxy == PROXY_TRACED_AND_MASQUERADED);
 
         if ($ip4h->protocol == PROTO_TCP) {
-          printf("[%s] [%p]   ↳ Detected TCP message, TCPFlags: %c%c%c%c%c%c%c%c, Seq: %u, Ack: %u\n",
+          printf("[%s] [%p]   ↳ TCP (TCPFlags: %c%c%c%c%c%c%c%c, Seq: %u, Ack: %u)\n",
             $time, $skb,
             $tcph->cwr ? CH_C : CH_DOT, $tcph->ece ? CH_E : CH_DOT,
             $tcph->urg ? CH_U : CH_DOT, $tcph->ack ? CH_A : CH_DOT,
@@ -188,7 +188,7 @@ kprobe:br_forward
         if ($ip4h->protocol == PROTO_UDP && (bswap($udph->source) == PORT_DNS || bswap($udph->dest) == PORT_DNS)) {
           $dns = (struct dnshdr*)($udph + 1);
           $query = (uint8 *)($dns + 1);
-          printf("[%s] [%p]   ↳ Detected DNS message, ID: %04x, flags %04x, QD: %d, AN: %d, NS: %d, AR: %d, query %s\n",
+          printf("[%s] [%p]   ↳ DNS (ID: %04x, flags %04x, QD: %d, AN: %d, NS: %d, AR: %d, query %s)\n",
             $time, $skb,
             bswap($dns->id), bswap($dns->flags), bswap($dns->qdcount),
             bswap($dns->ancount), bswap($dns->nscount), bswap($dns->arcount),
@@ -198,12 +198,12 @@ kprobe:br_forward
         if ($ip4h->protocol == PROTO_ICMP_IPV4) {
           $frag_off = bswap($ip4h->frag_off);
 
-          printf("[%s] [%p]   ↳ Detected ICMP message, IPFlags: .%c%c, Type: %u, Code: %u, FragOff: %d, FragID: %d\n",
+          printf("[%s] [%p]   ↳ ICMP (Type: %u, Code: %u, IPFlags: .%c%c, FragOff: %d, FragID: %d)\n",
             $time, $skb,
-            ($frag_off & 0x4000) >> 14 ? CH_D : CH_DOT,
-            ($frag_off & 0x2000) >> 13 ? CH_M : CH_DOT,
             $icmph->type,
             $icmph->code,
+            ($frag_off & 0x4000) >> 14 ? CH_D : CH_DOT,
+            ($frag_off & 0x2000) >> 13 ? CH_M : CH_DOT,
             $frag_off & 0x1FFF,
             bswap($ip4h->id));
         }
@@ -253,14 +253,14 @@ kprobe:br_forward
             $encap, $skb->encapsulation);
         }
 
-        printf("[%s] [%p]  ↳ %s:%d -> %s:%d (len: %d, proto: %d, ifindex: %d, netns: %x, srcPod: %d (internal: %d), dstPod: %d (internal: %d), proxy: %d (masqueraded: %d))\n",
+        printf("[%s] [%p]  ↳ %s:%d -> %s:%d (proto: %d, len: %d, ifindex: %d, netns: %x, srcPod: %d (internal: %d), dstPod: %d (internal: %d), proxy: %d (masqueraded: %d))\n",
           $time, $skb,
           ntop($ip6h->saddr.in6_u.u6_addr8),
           ($ip6h->nexthdr == PROTO_UDP || $ip6h->nexthdr == PROTO_TCP) ? bswap($udph->source) : 0,
           ntop($ip6h->daddr.in6_u.u6_addr8),
           ($ip6h->nexthdr == PROTO_UDP || $ip6h->nexthdr == PROTO_TCP) ? bswap($udph->dest) : 0,
-          bswap($ip6h->payload_len),
           $ip6h->nexthdr,
+          bswap($ip6h->payload_len),
           $skb->dev->ifindex,
           $skb->dev->nd_net.net->ns.inum,
           $src_is_pod, $src_is_internal,
@@ -269,7 +269,7 @@ kprobe:br_forward
           $pod_to_pod_via_proxy == PROXY_TRACED_AND_MASQUERADED);
 
         if ($ip6h->nexthdr == PROTO_TCP) {
-          printf("[%s] [%p]   ↳ Detected TCP message, TCPFlags: %c%c%c%c%c%c%c%c, Seq: %u, Ack: %u\n",
+          printf("[%s] [%p]   ↳ TCP (TCPFlags: %c%c%c%c%c%c%c%c, Seq: %u, Ack: %u)\n",
             $time, $skb,
             $tcph->cwr ? CH_C : CH_DOT, $tcph->ece ? CH_E : CH_DOT,
             $tcph->urg ? CH_U : CH_DOT, $tcph->ack ? CH_A : CH_DOT,
@@ -281,7 +281,7 @@ kprobe:br_forward
         if ($ip6h->nexthdr == PROTO_UDP && (bswap($udph->source) == PORT_DNS || bswap($udph->dest) == PORT_DNS)) {
           $dns = (struct dnshdr*)($udph + 1);
           $query = (uint8 *)($dns + 1);
-          printf("[%s] [%p]   ↳ Detected DNS message, ID: %04x, flags %04x, QD: %d, AN: %d, NS: %d, AR: %d, query %s\n",
+          printf("[%s] [%p]   ↳ DNS (ID: %04x, flags %04x, QD: %d, AN: %d, NS: %d, AR: %d, query %s)\n",
             $time, $skb,
             bswap($dns->id), bswap($dns->flags), bswap($dns->qdcount),
             bswap($dns->ancount), bswap($dns->nscount), bswap($dns->arcount),
@@ -298,11 +298,11 @@ kprobe:br_forward
             $frag_off_res_m = bswap($frag_hdr->frag_off);
           }
 
-          printf("[%s] [%p]   ↳ Detected ICMP message, IPFlags: ..%c, Type: %u, Code: %u, FragOff: %d, FragID: %d\n",
+          printf("[%s] [%p]   ↳ ICMP (Type: %u, Code: %u, IPFlags: ..%c, FragOff: %d, FragID: %d)\n",
             $time, $skb,
-            $frag_off_res_m & 0x0001 ? CH_M : CH_DOT,
             $icmph->type,
             $icmph->code,
+            $frag_off_res_m & 0x0001 ? CH_M : CH_DOT,
             $frag_off_res_m >> 3,
             $frag_id);
         }