Skip to content

Commit 75c7065

Browse files
committed
Make aquery spacing consistent
1 parent 71d3d0a commit 75c7065

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

refresh.template.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ def _get_commands(target: str, flags: str):
865865
target_statment = f'deps({target})'
866866
if {exclude_external_sources}:
867867
# For efficiency, have bazel filter out external targets (and therefore actions) before they even get turned into actions or serialized and sent to us. Note: this is a different mechanism than is used for excluding just external headers.
868-
target_statment = f"filter('^//',{target_statment})"
868+
target_statment = f"filter('^//', {target_statment})"
869869
if file_flags:
870870
file_path = file_flags[0]
871871
# For header file we try to find from hdrs and srcs to get the targets
@@ -881,7 +881,7 @@ def _get_commands(target: str, flags: str):
881881
# Aquery docs if you need em: https://docs.bazel.build/versions/master/aquery.html
882882
# Aquery output proto reference: https://github.com/bazelbuild/bazel/blob/master/src/main/protobuf/analysis_v2.proto
883883
# One bummer, not described in the docs, is that aquery filters over *all* actions for a given target, rather than just those that would be run by a build to produce a given output. This mostly isn't a problem, but can sometimes surface extra, unnecessary, misconfigured actions. Chris has emailed the authors to discuss and filed an issue so anyone reading this could track it: https://github.com/bazelbuild/bazel/issues/14156.
884-
f"mnemonic('(Objc|Cpp)Compile',{target_statment})",
884+
f"mnemonic('(Objc|Cpp)Compile', {target_statment})",
885885
# We switched to jsonproto instead of proto because of https://github.com/bazelbuild/bazel/issues/13404. We could change back when fixed--reverting most of the commit that added this line and tweaking the build file to depend on the target in that issue. That said, it's kinda nice to be free of the dependency, unless (OPTIMNOTE) jsonproto becomes a performance bottleneck compated to binary protos.
886886
'--output=jsonproto',
887887
# We'll disable artifact output for efficiency, since it's large and we don't use them. Small win timewise, but dramatically less json output from aquery.

0 commit comments

Comments
 (0)