Remove deprecated code. (#4324)

* Feat: replace system_rebuild_module_data()

* Feat: replace REQUEST_TIME

* Feat: replace format_date()

* Feat: remove update_fix_compatibility()

https://www.drupal.org/node/3026100

* Feat: replace user_load()

* Feat: replace CONFIG_SYNC_DIRECTORY

* Feat: replace drupal_get_profile()

* Feat: replace config_get_config_directory()

* Feat: replace prepareLegacyRequest()

* Feat: replace ResourcePluginManager->getInstance()

* Feat: replace Drupal\simpletest\TestDiscovery

* Feat: replace db_insert()

* Fix: module installed detection using module_handler service

* Remove the interaction part, because in Drupal 9 we have only one config folder.

* Use imports of the classes instead of full classified name of the class.

* Use dependency injection instead of direct call of \Drupal::service.

* Use dependency injection instead of direct call of \Drupal::service in Uninstall command class.

* Move vars outside loops.

* Use dependency injection instead of direct call of \Drupal::service in Manager class.

* Set Drupal console version 1.9.8.

Co-authored-by: Simon <s.foster@tabs-software.co.uk>

Author: LOBsTerr

config/services/debug.yml

@@ -67,7 +67,7 @@ services:
       - { name: drupal.command }
   console.module_debug:
     class: Drupal\Console\Command\Debug\ModuleCommand
-    arguments: ['@console.configuration_manager', '@console.site']
+    arguments: ['@console.configuration_manager', '@console.site', '@extension.list.module']
     tags:
       - { name: drupal.command }
   console.image_styles_debug:

config/services/module.yml

@@ -21,7 +21,7 @@ services:
       - { name: drupal.command }
   console.module_uninstall:
     class: Drupal\Console\Command\Module\UninstallCommand
-    arguments: ['@console.site','@module_installer', '@console.chain_queue', '@config.factory', '@console.extension_manager']
+    arguments: ['@console.site','@module_installer', '@console.chain_queue', '@config.factory', '@console.extension_manager', '@extension.list.module']
     tags:
       - { name: drupal.command }
   console.module_update:

src/Application.php

@@ -25,7 +25,7 @@ class Application extends BaseApplication
     /**
      * @var string
      */
-    const VERSION = '1.9.7';
+    const VERSION = '1.9.8';
 
     public function __construct(ContainerInterface $container)
     {

src/Command/Config/DiffCommand.php

@@ -8,6 +8,7 @@
 
 use Drupal\Core\Config\FileStorage;
 use Drupal\Core\Config\StorageComparer;
+use Drupal\Core\Site\Settings;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -78,36 +79,13 @@ protected function configure()
             )->setAliases(['cdi']);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function interact(InputInterface $input, OutputInterface $output)
-    {
-        global $config_directories;
-
-        $directory = $input->getArgument('directory');
-        if (!$directory) {
-            $directory = $this->getIo()->choice(
-                $this->trans('commands.config.diff.questions.directories'),
-                $config_directories,
-                CONFIG_SYNC_DIRECTORY
-            );
-
-            $input->setArgument('directory', $config_directories[$directory]);
-        }
-    }
-
     /**
      * {@inheritdoc}
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        global $config_directories;
-        $directory = $input->getArgument('directory') ?: CONFIG_SYNC_DIRECTORY;
-        if (array_key_exists($directory, $config_directories)) {
-            $directory = $config_directories[$directory];
-        }
-        $source_storage = new FileStorage($directory);
+        $config_directory = Settings::get('config_sync_directory');
+        $source_storage = new FileStorage($config_directory);
 
         if ($input->getOption('reverse')) {
             $config_comparer = new StorageComparer($source_storage, $this->configStorage, $this->configManager);

src/Command/Config/ExportCommand.php

@@ -11,6 +11,7 @@
 use Drupal\Component\Serialization\Yaml;
 use Drupal\Core\Config\ConfigManagerInterface;
 use Drupal\Core\Config\StorageInterface;
+use Drupal\Core\Site\Settings;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -83,7 +84,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
         if (!$input->getOption('directory')) {
             $directory = $this->getIo()->ask(
                 $this->trans('commands.config.export.questions.directory'),
-                config_get_config_directory(CONFIG_SYNC_DIRECTORY)
+                Settings::get('config_sync_directory')
             );
             $input->setOption('directory', $directory);
         }
@@ -102,7 +103,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $drupal_root = $this->drupalFinder->getComposerRoot();
 
         if (!$directory) {
-            $directory = config_get_config_directory(CONFIG_SYNC_DIRECTORY);
+            $directory = Settings::get('config_sync_directory') ;
         }
 
         $fileSystem = new Filesystem();

src/Command/Config/ExportSingleCommand.php

@@ -8,6 +8,7 @@
 namespace Drupal\Console\Command\Config;
 
 use Drupal\Component\Serialization\Yaml;
+use Drupal\Core\Site\Settings;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -304,7 +305,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 return 0;
             }
 
-            $directory = $directory_copy = config_get_config_directory(CONFIG_SYNC_DIRECTORY);
+            $directory = $directory_copy = Settings::get('config_sync_directory') ;
             if (!is_dir($directory)) {
                 if ($value) {
                     $directory = $directory_copy .'/' . str_replace('.', '/', $value);

src/Command/Config/ImportCommand.php

@@ -6,6 +6,7 @@
 
 namespace Drupal\Console\Command\Config;
 
+use Drupal\Core\Site\Settings;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -87,7 +88,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
         if (!$input->getOption('directory')) {
             $directory = $this->getIo()->ask(
                 $this->trans('commands.config.import.questions.directory'),
-                config_get_config_directory(CONFIG_SYNC_DIRECTORY)
+                Settings::get('config_sync_directory')
         );
             $input->setOption('directory', $directory);
         }

src/Command/Create/CommentsCommand.php

@@ -130,7 +130,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $nodeId = $input->getArgument('node-id')?:1;
-        $node = \Drupal\node\Entity\Node::load($nodeId);
+        $node = Node::load($nodeId);
         if (empty($node)) {
             throw new \InvalidArgumentException(
                 $this->trans(

src/Command/Cron/ExecuteCommand.php

@@ -108,7 +108,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
-        $this->state->set('system.cron_last', REQUEST_TIME);
+        $this->state->set('system.cron_last', \Drupal::time()->getRequestTime());
         $this->lock->release('cron');
 
         $this->getIo()->success($this->trans('commands.cron.execute.messages.success'));

src/Command/Debug/ModuleCommand.php

@@ -14,6 +14,7 @@
 use Drupal\Console\Core\Command\Command;
 use Drupal\Console\Utils\Site;
 use Drupal\Console\Core\Utils\ConfigurationManager;
+use Drupal\Core\Extension\ModuleExtensionList;
 
 class ModuleCommand extends Command
 {
@@ -27,18 +28,31 @@ class ModuleCommand extends Command
      */
     protected $site;
 
+    /**
+     * @var Site
+     */
+    protected $module;
+
+    /**
+     * @var Drupal\Core\Extension\ModuleExtensionList
+     */
+    protected $extensionList;
+
     /**
      * ChainDebugCommand constructor.
      *
      * @param ConfigurationManager $configurationManager
      * @param Site                 $site
+     * @param ModuleExtensionList  $extensionList
      */
     public function __construct(
         ConfigurationManager $configurationManager,
-        Site $site
+        Site $site,
+        ModuleExtensionList $extensionList
     ) {
         $this->configurationManager = $configurationManager;
         $this->site = $site;
+        $this->extensionList = $extensionList;
         parent::__construct();
     }
 
@@ -117,7 +131,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
     private function getModules($status, $type, $modules) {
 
         $result = [];
-        $modulesData = system_rebuild_module_data();
+        $modulesData = $this->extensionList->reset()->getList();
 
         if(!$modules) {
             $modules = array_keys($modulesData) ;