qml: Remove explicit height of BlockCounter

promag · promag · commit 6bedd3de45e2 · 2021-11-02T10:41:48.000Z
Label implicit height depends on the font size but the font size depends
on the label height. This results in a runtime anchor loop warning.
diff --git a/src/qml/components/BlockCounter.qml b/src/qml/components/BlockCounter.qml
@@ -18,6 +18,6 @@ Label {
     verticalAlignment: Text.AlignVCenter
     font.family: "Inter"
     font.styleName: "Semi Bold"
-    font.pixelSize: height / 3
+    font.pixelSize: 20
     text: blockHeight
 }
diff --git a/src/qml/pages/stub.qml b/src/qml/pages/stub.qml
@@ -29,7 +29,6 @@ ApplicationWindow {
     BitcoinCoreComponents.BlockCounter {
         id: blockCounter
         anchors.centerIn: parent
-        height: parent.height / 3
         blockHeight: nodeModel.blockTipHeight
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,6 @@ Label {`
`18`	`18`	`verticalAlignment: Text.AlignVCenter`
`19`	`19`	`font.family: "Inter"`
`20`	`20`	`font.styleName: "Semi Bold"`
`21`		`- font.pixelSize: height / 3`
	`21`	`+ font.pixelSize: 20`
`22`	`22`	`text: blockHeight`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ ApplicationWindow {`
`29`	`29`	`BitcoinCoreComponents.BlockCounter {`
`30`	`30`	`id: blockCounter`
`31`	`31`	`anchors.centerIn: parent`
`32`		`- height: parent.height / 3`
`33`	`32`	`blockHeight: nodeModel.blockTipHeight`
`34`	`33`	`}`
`35`	`34`	`}`