Merge #180: cmake: Port PR29890 from the master branch

772769a fixup! cmake: Add `Maintenance` module (Hennadii Stepanov)
fa36e33 fixup! cmake: Add platform-specific linker flags (Hennadii Stepanov)
c6dc19f fixup! build: Generate `toolchain.cmake` in depends (Hennadii Stepanov)
cddeb04 fixup! cmake: Add root `CMakeLists.txt` file (Hennadii Stepanov)

Pull request description:

  This PR ports bitcoin#29890 and fixes cross-compiling for macOS been broken since the recent sync/rebase [PR](#179).

ACKs for top commit:
  m3dwards:
    Giving a utACK 772769a

Tree-SHA512: f0f10317b1fd5e46d1b7f340f4efb9f1b27a6a7a9b11191736c8edf32c278ba6d9ca4ef38d03a78cb40d58637e7e9746020b264a3f7eeb9903c23cb726f18fbf

Author: hebasto

CMakeLists.txt

@@ -15,6 +15,9 @@ if(POLICY CMP0141)
 endif()
 cmake_minimum_required(VERSION 3.22)
 
+#=============================
+# Project / Package metadata
+#=============================
 set(PACKAGE_NAME "Bitcoin Core")
 set(CLIENT_VERSION_MAJOR 27)
 set(CLIENT_VERSION_MINOR 99)
@@ -27,7 +30,7 @@ project(BitcoinCore
   VERSION ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_BUILD}
   DESCRIPTION "Bitcoin client software"
   HOMEPAGE_URL "https://bitcoincore.org/"
-  LANGUAGES CXX
+  LANGUAGES NONE
 )
 
 set(PACKAGE_VERSION ${PROJECT_VERSION})
@@ -39,6 +42,15 @@ set(COPYRIGHT_HOLDERS "The %s developers")
 set(COPYRIGHT_HOLDERS_FINAL "The ${PACKAGE_NAME} developers")
 set(PACKAGE_BUGREPORT "https://github.com/bitcoin/bitcoin/issues")
 
+#=============================
+# Language setup
+#=============================
+if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND NOT CMAKE_HOST_APPLE)
+  # We do not use the install_name_tool when cross-compiling for macOS.
+  # So disable this tool check in further enable_language() commands.
+  set(CMAKE_PLATFORM_HAS_INSTALLNAME FALSE)
+endif()
+enable_language(CXX)
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
@@ -253,7 +265,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
   # "ad_strip" as the symbol for the entry point.
   try_append_linker_flag("-Wl,-dead_strip" TARGET core_base_interface)
   try_append_linker_flag("-Wl,-dead_strip_dylibs" TARGET core_base_interface)
-  try_append_linker_flag("-Wl,-headerpad_max_install_names" TARGET core_base_interface)
+  if(CMAKE_HOST_APPLE)
+    try_append_linker_flag("-Wl,-headerpad_max_install_names" TARGET core_base_interface)
+  endif()
 endif()
 
 include(AddThreadsIfNeeded)

cmake/module/Maintenance.cmake

@@ -114,7 +114,7 @@ function(add_macos_deploy_target)
     if(CMAKE_CROSSCOMPILING)
       add_custom_command(
         OUTPUT ${CMAKE_BINARY_DIR}/dist/${macos_app}/Contents/MacOS/Bitcoin-Qt
-        COMMAND INSTALL_NAME_TOOL=${CMAKE_INSTALL_NAME_TOOL} OTOOL=${OTOOL} STRIP=${CMAKE_STRIP} ${PYTHON_COMMAND} ${CMAKE_SOURCE_DIR}/contrib/macdeploy/macdeployqtplus ${macos_app} ${osx_volname} -translations-dir=${QT_TRANSLATIONS_DIR}
+        COMMAND OTOOL=${OTOOL} ${PYTHON_COMMAND} ${CMAKE_SOURCE_DIR}/contrib/macdeploy/macdeployqtplus ${macos_app} ${osx_volname} -translations-dir=${QT_TRANSLATIONS_DIR}
         DEPENDS ${CMAKE_BINARY_DIR}/${macos_app}/Contents/MacOS/Bitcoin-Qt
         VERBATIM
       )

depends/Makefile

@@ -269,7 +269,6 @@ $(host_prefix)/toolchain.cmake : toolchain.cmake.in $(host_prefix)/.stamp_$(fina
             -e 's|@RANLIB@|$(host_RANLIB)|' \
             -e 's|@STRIP@|$(host_STRIP)|' \
             -e 's|@OBJCOPY@|$(host_OBJCOPY)|' \
-            -e 's|@INSTALL_NAME_TOOL@|$(host_INSTALL_NAME_TOOL)|' \
             -e 's|@OTOOL@|$(host_OTOOL)|' \
             -e 's|@depends_prefix@|$(host_prefix)|' \
             -e 's|@CFLAGS@|$(strip $(host_CFLAGS))|' \

depends/toolchain.cmake.in

@@ -87,7 +87,6 @@ set(CMAKE_AR "@AR@")
 set(CMAKE_RANLIB "@RANLIB@")
 set(CMAKE_STRIP "@STRIP@")
 set(CMAKE_OBJCOPY "@OBJCOPY@")
-set(CMAKE_INSTALL_NAME_TOOL "@INSTALL_NAME_TOOL@")
 set(OTOOL "@OTOOL@")
 
 # Using our own built dependencies should not be