Remove dependency on ORM adapter by implementing our own methods#5823
Draft
carlosantoniodasilva wants to merge 5 commits intomainfrom
Draft
Remove dependency on ORM adapter by implementing our own methods#5823carlosantoniodasilva wants to merge 5 commits intomainfrom
carlosantoniodasilva wants to merge 5 commits intomainfrom
Conversation
Where things may diverge that we need specific logic between each ORM, we can implement our own finders / query methods, since we have already a base for this with dirty tracking anyway. This eliminates a dependency that's been around since the very beginning of Devise.
carlosantoniodasilva
force-pushed
the
ca-rm-orm-adapter
branch
from
92256d6 to
3057aa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where things may diverge that we need specific logic between each ORM,
we can implement our own finders / query methods, since we have already
a base for this with dirty tracking anyway.
This eliminates a dependency that's been around since the very beginning
of Devise.