Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for crontstrue dependency in cronjob/List.tsx #2374

Open
2 tasks
illume opened this issue Oct 1, 2024 · 1 comment
Open
2 tasks

Add test for crontstrue dependency in cronjob/List.tsx #2374

illume opened this issue Oct 1, 2024 · 1 comment
Labels
e2e-tests End to end tests frontend Issues related to the frontend good first issue Good for newcomers testing

Comments

@illume
Copy link
Collaborator

illume commented Oct 1, 2024

Because frontend/src/components/cronjob/List.tsx does not have stories.

This is important because every "cronstrue" dependency update needs manual testing.

There are two different ways to test this. Either one would be ok.

  • Add frontend/src/components/cronjob/List.stories.tsx
  • Add e2e test for the cronjob list page
@illume illume added good first issue Good for newcomers frontend Issues related to the frontend testing labels Oct 1, 2024
@dosubot dosubot bot added the e2e-tests End to end tests label Oct 1, 2024
@illume illume changed the title Add test for cronjob/List.tsx needs tests/stories Add test for crontstrue dependency in cronjob/List.tsx Oct 2, 2024
@Dharmil4602
Copy link

I can take this issue and work on it. Please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e2e-tests End to end tests frontend Issues related to the frontend good first issue Good for newcomers testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@illume @Dharmil4602