Skip to content

Commit 0aad1bb

Browse files
authored
Use a location of cudd with a stable git hash. (#399)
Using archive links from github is dangerous as they can change any time, as they build them on-the-fly, so hashing the file can create unstable hashes: https://github.blog/open-source/git/update-on-the-future-stability-of-source-code-archives-and-hashes/ (Unlike for instance nix, bazel does not hash the content of a tar but the binary tar.gz itself, so it is prone to run into the issue) Fix that by using another source that is providing the tar.gz itself, so is stable. Note: this will change this dependency from `@com_github_ivmai_cudd` to `@com_github_davidkebo_cudd`
1 parent 670188e commit 0aad1bb

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

dependency_support/com_github_ivmai_cudd/bundled.BUILD.bazel renamed to dependency_support/com_github_davidkebo_cudd/bundled.BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ cc_library(
140140

141141
genrule(
142142
name = "config",
143-
srcs = ["@rules_hdl//dependency_support/com_github_ivmai_cudd:config.h"],
143+
srcs = ["@rules_hdl//dependency_support/com_github_davidkebo_cudd:config.h"],
144144
outs = ["config.h"],
145-
cmd = "cat $(location @rules_hdl//dependency_support/com_github_ivmai_cudd:config.h) > $@",
146-
)
145+
cmd = "cat $(location @rules_hdl//dependency_support/com_github_davidkebo_cudd:config.h) > $@",
146+
)

dependency_support/com_github_ivmai_cudd/com_github_ivmai_cudd.bzl renamed to dependency_support/com_github_davidkebo_cudd/com_github_davidkebo_cudd.bzl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
1818
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
1919

20-
def com_github_ivmai_cudd():
20+
def com_github_davidkebo_cudd():
2121
maybe(
2222
http_archive,
23-
name = "com_github_ivmai_cudd",
23+
name = "com_github_davidkebo_cudd",
2424
urls = [
25-
"https://github.com/ivmai/cudd/archive/f54f533303640afd5dbe47a05ebeabb3066f2a25.zip",
25+
"https://github.com/davidkebo/cudd/raw/refs/heads/main/cudd_versions/cudd-3.0.0.tar.gz",
2626
],
27-
strip_prefix = "cudd-f54f533303640afd5dbe47a05ebeabb3066f2a25",
28-
sha256 = "",
29-
build_file = Label("//dependency_support/com_github_ivmai_cudd:bundled.BUILD.bazel"),
27+
strip_prefix = "cudd-3.0.0",
28+
sha256 = "b8e966b4562c96a03e7fbea239729587d7b395d53cadcc39a7203b49cf7eeb69",
29+
build_file = "//dependency_support/com_github_davidkebo_cudd:bundled.BUILD.bazel",
3030
)

dependency_support/dependency_support.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ load("//dependency_support/at_clifford_icestorm:at_clifford_icestorm.bzl", "at_c
2222
load("//dependency_support/at_clifford_yosys:at_clifford_yosys.bzl", "at_clifford_yosys")
2323
load("//dependency_support/bazel_skylib:bazel_skylib.bzl", "bazel_skylib")
2424
load("//dependency_support/boost:boost.bzl", "boost")
25+
load("//dependency_support/com_github_davidkebo_cudd:com_github_davidkebo_cudd.bzl", "com_github_davidkebo_cudd")
2526
load("//dependency_support/com_github_fmtlib_fmt:com_github_fmtlib_fmt.bzl", "com_github_fmtlib_fmt")
2627
load("//dependency_support/com_github_gabime_spdlog:com_github_gabime_spdlog.bzl", "com_github_gabime_spdlog")
27-
load("//dependency_support/com_github_ivmai_cudd:com_github_ivmai_cudd.bzl", "com_github_ivmai_cudd")
2828
load("//dependency_support/com_github_libbacktrace:com_github_libbacktrace.bzl", "com_github_libbacktrace")
2929
load("//dependency_support/com_github_ninja_build_ninja:com_github_ninja_build_ninja.bzl", "com_github_ninja_build_ninja")
3030
load("//dependency_support/com_github_quantamhd_lemon:com_github_quantamhd_lemon.bzl", "com_github_quantamhd_lemon")
@@ -78,7 +78,7 @@ def dependency_support(register_toolchains = True):
7878
boost()
7979
com_github_fmtlib_fmt()
8080
com_github_gabime_spdlog()
81-
com_github_ivmai_cudd()
81+
com_github_davidkebo_cudd()
8282
com_github_libbacktrace()
8383
com_github_ninja_build_ninja()
8484
com_github_quantamhd_lemon()

0 commit comments

Comments
 (0)