Refactor video attributes #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Abstract video attributes and video ID code lookup into a package - All video attributes are now static values rather than signals within the hdmi block. The width/height output signals are removed since they are available by accessing hdmi localparams or through the hdmi_attr package. - Allow using custom video attributes if desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gbaHD no longer needs custom video timings, but this refactoring makes it easier if anyone ever does.
within the hdmi block. The width/height output signals are removed
since they are available by accessing hdmi localparams or through the
hdmi_attr package.