使用 strandjs 风格并添加 eslint

Author: lmk123

.eslintrc

@@ -0,0 +1,18 @@
+{
+  "globals": {
+    "chrome": false,
+    "ES6Promise": false,
+    "chromeCall": false
+  },
+  "env": {
+    "browser": true,
+    "amd": true,
+    "jasmine": true
+  },
+  "plugins": [
+    "html"
+  ],
+  "extends": [
+    "standard"
+  ]
+}

.travis.yml

@@ -1,7 +1,7 @@
 language: node_js
 
 node_js:
-  - "4"
+  - "node"
 
 before_install:
   - npm install -g npm

chrome-call.js

@@ -1,15 +1,15 @@
-(function ( root , factory ) {
+(function (root, factory) {
   /* istanbul ignore next */
-  if ( typeof module === 'object' && typeof module.exports === 'object' ) {
-    module.exports = factory();
-  } else if ( typeof define === 'function' && define.amd ) {
-    define( [] , factory );
+  if (typeof module === 'object' && typeof module.exports === 'object') {
+    module.exports = factory()
+  } else if (typeof define === 'function' && define.amd) {
+    define([], factory)
   } else {
-    root[ 'chromeCall' ] = factory();
+    root['chromeCall'] = factory()
   }
-})( this , function () {
-  'use strict';
-  var runtime = chrome.runtime;
+})(this, function () {
+  'use strict'
+  var runtime = chrome.runtime
 
   /**
    * 根据 base 对象返回指定路径的栈
@@ -20,88 +20,89 @@
    * @example
    *   pathStack('document.body',window) 应该返回 [window,window.document,window.document.body]
    */
-  function pathStack( path , base ) {
-    var keys = path.split( '.' ) ,
-      stack = [ base ];
+  function pathStack (path, base) {
+    var keys = path.split('.')
+    var stack = [base]
 
-    keys.forEach( function ( key , i ) {
-      var val = stack[ i ][ key ];
-      if ( !val ) {
-        throw new Error( 'Cannot find "' + path + '".' );
+    keys.forEach(function (key, i) {
+      var val = stack[i][key]
+      if (!val) {
+        throw new Error('Cannot find "' + path + '".')
       }
-      stack.push( val );
-    } );
+      stack.push(val)
+    })
 
-    return stack;
+    return stack
   }
 
   /**
    * 根据基础对象返回一个函数，此函数会以基础对象为起点寻找指定属性并调用
    * @param {String|Object} base
    * @returns {Function}
    */
-  function scope( base ) {
-    var baseObj = typeof base === 'string' ? pathStack( base , chrome ).pop() : base;
+  function scope (base) {
+    var baseObj = typeof base === 'string' ? pathStack(base, chrome).pop() : base
 
     /**
      * 调用原本的 chrome api 并返回一个 Promise
      * @param {Boolean} [returnArray] - 当函数的第一个值是 true 时，则 Promise 会返回一个数组，包含 callback 的所有参数
      * @param {String} fnPath - 原本的 chrome api 的路径，相对于 chrome，如 storage.local.get
      * @returns {Promise}
      */
-    return function ( /*returnArray , fnPath , ...args*/ ) {
-      // inline copy arguments, see https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-      var length = arguments.length ,
-        argumentsArray = [];
+    return function (/* returnArray , fnPath , ...args */) {
+      // inline copy arguments,
+      // see https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
+      var length = arguments.length
+      var argumentsArray = []
 
-      for ( var i = 0 ; i < length ; i += 1 ) {
-        argumentsArray[ i ] = arguments[ i ];
+      for (var i = 0; i < length; i += 1) {
+        argumentsArray[i] = arguments[i]
       }
 
-      var returnArray = argumentsArray.shift() ,
-        fnPath;
+      var returnArray = argumentsArray.shift()
+      var fnPath
 
-      if ( typeof returnArray === 'boolean' ) {
-        fnPath = argumentsArray.shift();
+      if (typeof returnArray === 'boolean') {
+        fnPath = argumentsArray.shift()
       } else {
-        fnPath = returnArray;
-        returnArray = false;
+        fnPath = returnArray
+        returnArray = false
       }
 
       // Step 1: find the function which need to be call
-      var stack = pathStack( fnPath , baseObj );
+      var stack = pathStack(fnPath, baseObj)
 
-      var args = argumentsArray;
-      return new Promise( function ( resolve , reject ) {
+      var args = argumentsArray
+      return new Promise(function (resolve, reject) {
         // Step 2: inject callback
-        args.push( function () {
-          var lastError = runtime.lastError;
-          if ( lastError ) {
-            reject( lastError );
-            return;
+        args.push(function () {
+          var lastError = runtime.lastError
+          if (lastError) {
+            reject(lastError)
+            return
           }
 
-          if ( returnArray ) {
-            var length = arguments.length ,
-              argumentsArray = [];
+          if (returnArray) {
+            var length = arguments.length
+            var argumentsArray = []
 
-            for ( var i = 0 ; i < length ; i += 1 ) {
-              argumentsArray[ i ] = arguments[ i ];
+            for (var i = 0; i < length; i += 1) {
+              argumentsArray[i] = arguments[i]
             }
 
-            resolve( argumentsArray );
+            resolve(argumentsArray)
           } else {
-            resolve( arguments[ 0 ] );
+            resolve(arguments[0])
           }
-        } );
+        })
 
         // Step 3: call function with it's original "this"
-        stack.pop().apply( stack.pop() , args );
-      } );
-    };
+        stack.pop().apply(stack.pop(), args)
+      })
+    }
   }
 
-  var defaultCp = scope( chrome );
-  defaultCp.scope = scope;
-  return defaultCp;
-} );
+  var defaultCp = scope(chrome)
+  defaultCp.scope = scope
+  return defaultCp
+})

karma.conf.js

@@ -1,37 +1,37 @@
-module.exports = function ( config ) {
-  config.set( {
-    basePath : '' ,
-    frameworks : [ 'jasmine' ] ,
-    files : [
-      'node_modules/es6-promise/dist/es6-promise.js' ,
-      'test/helper.js' ,
-      'chrome-call.js' ,
+module.exports = function (config) {
+  config.set({
+    basePath: '',
+    frameworks: ['jasmine'],
+    files: [
+      'node_modules/es6-promise/dist/es6-promise.js',
+      'test/helper.js',
+      'chrome-call.js',
       'test/test.js'
-    ] ,
-    preprocessors : {
-      'chrome-call.js' : [ 'coverage' ]
-    } ,
-    reporters : [ 'progress' , 'coverage' ] ,
-    coverageReporter : {
-      dir : 'coverage' ,
-      reporters : [
+    ],
+    preprocessors: {
+      'chrome-call.js': ['coverage']
+    },
+    reporters: ['progress', 'coverage'],
+    coverageReporter: {
+      dir: 'coverage',
+      reporters: [
         {
-          type : 'html' ,
-          subdir : function ( browser ) {
-            return 'html/' + browser.toLowerCase().split( /[ /-]/ )[ 0 ];
+          type: 'html',
+          subdir: function (browser) {
+            return 'html/' + browser.toLowerCase().split(/[ /-]/)[0]
           }
-        } ,
+        },
         {
-          type : 'lcov' ,
-          subdir : 'lcov'
+          type: 'lcov',
+          subdir: 'lcov'
         }
       ]
-    } ,
-    port : 9876 ,
-    colors : true ,
-    logLevel : config.LOG_INFO ,
-    autoWatch : false ,
-    browsers : [ 'Firefox' , 'Chrome' , 'IE' , 'PhantomJS' ] ,
-    singleRun : true
-  } )
-};
+    },
+    port: 9876,
+    colors: true,
+    logLevel: config.LOG_INFO,
+    autoWatch: false,
+    browsers: ['Chrome', 'PhantomJS'],
+    singleRun: true
+  })
+}

package.json

@@ -11,21 +11,24 @@
     "url": "https://github.com/lmk123/chrome-call/issues"
   },
   "scripts": {
-    "test": "karma start"
+    "test": "karma start",
+    "lint": "eslint --ignore-pattern '/dist/' \"**/*.{js,vue}\""
   },
   "devDependencies": {
-    "es6-promise": "^3.0.2",
-    "phantomjs": "^1.9.18",
-    "jasmine-core": "^2.4.1",
-    "karma": "^0.13.14",
-    "karma-chrome-launcher": "^0.2.1",
-    "karma-firefox-launcher": "^0.1.6",
-    "karma-ie-launcher": "^0.2.0",
-    "karma-jasmine": "^0.3.6",
-    "karma-phantomjs-launcher": "^0.2.1",
-    "karma-safari-launcher": "^0.1.1",
-    "karma-coverage": "^0.5.3",
-    "karma-coveralls": "^1.1.2"
+    "es6-promise": "4.0.5",
+    "phantomjs-prebuilt": "2.1.13",
+    "jasmine-core": "2.5.2",
+    "karma": "1.3.0",
+    "karma-chrome-launcher": "2.0.0",
+    "karma-jasmine": "1.0.2",
+    "karma-phantomjs-launcher": "1.0.2",
+    "karma-safari-launcher": "1.0.0",
+    "karma-coverage": "1.1.1",
+    "karma-coveralls": "1.1.2",
+    "eslint": "3.8.1",
+    "eslint-config-standard": "6.2.0",
+    "eslint-plugin-promise": "3.3.0",
+    "eslint-plugin-standard": "2.0.1"
   },
   "keywords": [
     "chrome",

test/helper.js

@@ -1,4 +1,4 @@
-ES6Promise.polyfill();
+ES6Promise.polyfill()
 window.chrome = {
-  runtime : {}
-};
+  runtime: {}
+}