测试完成

Author: lmk123

.gitignore

@@ -0,0 +1,2 @@
+/node_modules/
+/coverage/

chrome-call.js

@@ -1,4 +1,5 @@
 (function ( root , factory ) {
+  /* istanbul ignore next */
   if ( typeof module === 'object' && typeof module.exports === 'object' ) {
     module.exports = factory();
   } else if ( typeof define === 'function' && define.amd ) {
@@ -7,23 +8,21 @@
     root[ 'chromeCall' ] = factory();
   }
 })( this , function () {
-  var ap = Array.prototype ,
-    slice = ap.slice ,
-    push = ap.push ,
+  var slice = Array.prototype.slice ,
     runtime = chrome.runtime;
 
   /**
-   * 根据 base 对象返回指定路径的属性
+   * 根据 base 对象返回指定路径的栈
    * @param {String} path - 属性路径，可用点（.）分隔
    * @param {String|Object} base - 开始查找的那个对象
    * @returns {*[]}
    *
    * @example
-   *   findPaths('document.body',window) 应该返回 [window,window.document,document.body]
+   *   pathStack('document.body',window) 应该返回 [window,window.document,window.document.body]
    */
-  function findPaths( path , base ) {
+  function pathStack( path , base ) {
     if ( typeof base === 'string' ) {
-      base = findPaths( base , chrome );
+      base = pathStack( base , chrome ).pop();
     }
 
     var keys = path.split( '.' ) ,
@@ -48,29 +47,23 @@
   function scope( base ) {
     return function ( fnPath /*, ...args*/ ) {
       // Step 1: find the function which need to be call
-      var paths = findPaths( fnPath , base );
+      var paths = pathStack( fnPath , base );
 
       var args = slice.call( arguments , 1 );
       return new Promise( function ( resolve , reject ) {
         // Step 2: inject callback
-        push.call( args , function () {
+        args.push( function () {
           var lastError = runtime.lastError;
           if ( lastError ) {
             reject( lastError );
             return;
           }
 
-          var length = arguments.length;
-          if ( length ) {
-            resolve( length === 1 ? arguments[ 0 ] : slice.call( arguments , 0 ) );
-          } else {
-            resolve();
-          }
+          resolve( arguments.length <= 1 ? arguments[ 0 ] : slice.call( arguments , 0 ) );
         } );
 
         // Step 3: call function with it's original "this"
-        var length = paths.length;
-        paths[ length - 1 ].apply( paths[ length - 2 ] , args );
+        paths.pop().apply( paths.pop() , args );
       } );
     };
   }

karma.conf.js

@@ -0,0 +1,37 @@
+module.exports = function ( config ) {
+  config.set( {
+    basePath : '' ,
+    frameworks : [ 'jasmine' ] ,
+    files : [
+      'node_modules/es6-promise/dist/es6-promise.js' ,
+      'test/helper.js' ,
+      'chrome-call.js' ,
+      'test/test.js'
+    ] ,
+    preprocessors : {
+      'chrome-call.js' : [ 'coverage' ]
+    } ,
+    reporters : [ 'progress' , 'coverage' ] ,
+    coverageReporter : {
+      dir : 'coverage' ,
+      reporters : [
+        {
+          type : 'html' ,
+          subdir : function ( browser ) {
+            return 'html/' + browser.toLowerCase().split( /[ /-]/ )[ 0 ];
+          }
+        } ,
+        {
+          type : 'lcov' ,
+          subdir : 'lcov'
+        }
+      ]
+    } ,
+    port : 9876 ,
+    colors : true ,
+    logLevel : config.LOG_INFO ,
+    autoWatch : false ,
+    browsers : [ 'Firefox' , 'Chrome' , 'IE' , 'PhantomJS' ] ,
+    singleRun : true
+  } )
+};

package.json

@@ -10,6 +10,23 @@
   "bugs": {
     "url": "https://github.com/lmk123/chrome-call/issues"
   },
+  "scripts": {
+    "test": "karma start"
+  },
+  "devDependencies": {
+    "es6-promise": "^3.0.2",
+    "phantomjs": "^1.9.18",
+    "jasmine-core": "^2.4.1",
+    "karma": "^0.13.14",
+    "karma-chrome-launcher": "^0.2.1",
+    "karma-firefox-launcher": "^0.1.6",
+    "karma-ie-launcher": "^0.2.0",
+    "karma-jasmine": "^0.3.6",
+    "karma-phantomjs-launcher": "^0.2.1",
+    "karma-safari-launcher": "^0.1.1",
+    "karma-coverage": "^0.5.3",
+    "karma-coveralls": "^1.1.2"
+  },
   "keywords": [
     "chrome",
     "ext",

test/helper.js

@@ -0,0 +1,4 @@
+ES6Promise.polyfill();
+window.chrome = {
+  runtime : {}
+};

test/test.js

@@ -0,0 +1,145 @@
+chrome.storage = {
+  local : {
+    remove : function () {}
+  }
+};
+
+describe( 'chromeCall' , function () {
+  describe( '调用 chorme api 时' , function () {
+
+    beforeEach( function () {
+      spyOn( chrome.storage.local , 'remove' ).and.callFake( function ( key , value , cb ) {
+        expect( this ).toBe( chrome.storage.local );
+        expect( key ).toBe( 'a' );
+        expect( value ).toBe( 'b' );
+        expect( typeof cb ).toBe( 'function' );
+        setTimeout( function () {
+          cb( 'c' );
+        } , 100 );
+      } );
+    } );
+
+    it( '若正常执行则 resolve promise' , function ( done ) {
+      chromeCall( 'storage.local.remove' , 'a' , 'b' )
+        .then( function ( value ) {
+          expect( value ).toBe( 'c' );
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+    it( '若执行时出错则会 reject promise' , function ( done ) {
+      chrome.runtime.lastError = 'hello error';
+      chromeCall( 'storage.local.remove' , 'a' , 'b' )
+        .then( function () {
+          fail( '没有进入 reject 分支' );
+          chrome.runtime.lastError = null;
+          done();
+        } , function ( error ) {
+          expect( error ).toBe( 'hello error' );
+          chrome.runtime.lastError = null;
+          done();
+        } );
+    } );
+
+  } );
+
+  describe( '调用的 chrome api' , function () {
+    beforeEach( function () {
+      spyOn( chrome.storage.local , 'remove' );
+    } );
+
+    it( '若没有返回参数则 resolve 函数的参数为零' , function ( done ) {
+      chrome.storage.local.remove.and.callFake( function ( cb ) {
+        cb();
+      } );
+      chromeCall( 'storage.local.remove' )
+        .then( function ( x ) {
+          expect( x ).toBeUndefined();
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+    it( '若只返回了一个参数则 resolve 函数的参数为一且值为那个参数' , function ( done ) {
+      chrome.storage.local.remove.and.callFake( function ( cb ) {
+        cb( 'x' );
+      } );
+      chromeCall( 'storage.local.remove' )
+        .then( function ( value ) {
+          expect( value ).toBe( 'x' );
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+    it( '若返回了一个两个或更多参数则 resolve 函数的参数为一个真实的数组，包含那些参数' , function ( done ) {
+      chrome.storage.local.remove.and.callFake( function ( cb ) {
+        cb( 'x' , 'y' , 'z' );
+      } );
+      chromeCall( 'storage.local.remove' )
+        .then( function ( value ) {
+          expect( value ).toEqual( [ 'x' , 'y' , 'z' ] );
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+  } );
+
+  it( '若找不到指定的路径则会报错' , function () {
+    expect( function () {
+      chromeCall( 'x.y.z' );
+    } ).toThrow();
+  } );
+
+  describe( '作用域' , function () {
+
+    beforeEach( function () {
+      spyOn( chrome.storage.local , 'remove' );
+    } );
+
+    it( '可以用字符串声明' , function ( done ) {
+      var local = chromeCall.scope( 'storage.local' );
+
+      chrome.storage.local.remove.and.callFake( function ( cb ) {
+        cb( 'hi' );
+      } );
+
+      local( 'remove' )
+        .then( function ( x ) {
+          expect( x ).toBe( 'hi' );
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+    it( '可以直接用对象声明' , function ( done ) {
+      var local = chromeCall.scope( chrome.storage.local );
+
+      chrome.storage.local.remove.and.callFake( function ( cb ) {
+        cb( 'hi' );
+      } );
+
+      local( 'remove' )
+        .then( function ( x ) {
+          expect( x ).toBe( 'hi' );
+          done();
+        } , function () {
+          fail( '没有进入 resolve 分支' );
+          done();
+        } );
+    } );
+
+  } );
+} );