-
Notifications
You must be signed in to change notification settings - Fork 44
Bump svg-path from 6.3 to 7.0 #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [svg-path](https://github.com/regebro/svg.path) from 6.3 to 7.0. - [Changelog](https://github.com/regebro/svg.path/blob/master/CHANGES.txt) - [Commits](regebro/svg.path@6.3...7.0) --- updated-dependencies: - dependency-name: svg-path dependency-version: '7.0' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Reviewer's GuideThis PR upgrades the svg.path dependency from version 6.3 to 7.0 in the project requirements, leveraging its new PathSegment typing for Move commands and Path slicing support. Class diagram for svg.path 7.0: Move is now a PathSegmentclassDiagram
class PathSegment {
}
class Move {
}
class Path {
+__getitem__(slice) Path
}
PathSegment <|-- Move
%% Move is now a subclass of PathSegment
%% Path supports slicing to return Path
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 5fa3257 in 20 seconds. Click for details.
- Reviewed
9lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. requirements.txt:3
- Draft comment:
Bump to svg.path 7.0 introduces breaking API changes (e.g., Move is now a PathSegment). Ensure any usage expecting the previous behavior is updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about a dependency change, specifically mentioning breaking API changes due to a version bump. It advises ensuring that any usage expecting the previous behavior is updated. This falls under the rule of not commenting on dependency changes or library versions that are not recognized. Therefore, this comment should be removed.
Workflow ID: wflow_ZnSQMicvyqGOsMvk
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|



Bumps svg-path from 6.3 to 7.0.
Changelog
Sourced from svg-path's changelog.
Commits
bf9e86aPreparing release 7.074191ccImplement slices (#111)5129af1Make Move a Path segment (#110)60dbedcBack to development: 6.4b2dfde531Preparing release 6.4b18047b32What about NOW?5289340fixed a typc076f8aType annotations. (#108)de85b7ctests: Use better than nothing fontb928a7fGetting rid of setup.py and updating Python versions (#106)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by Sourcery
Update svg.path to version 7.0 to include path slicing support and align Move commands as PathSegments
New Features:
Chores: