Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training loss can not converge with custome cropped dataset. #23

Closed
hot-dog opened this issue May 10, 2024 · 4 comments
Closed

Training loss can not converge with custome cropped dataset. #23

hot-dog opened this issue May 10, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@hot-dog
Copy link

hot-dog commented May 10, 2024

Thanks for your great work! I tried with my own data and the training loss could not converge, all the training parameters are default. My data has been cropped and the principal point does not locate on the center of the image, i have modified the projection matrix accordingly and these modifications works fine with 3DGS, but do not work with 2DGS. I have no idea how to fix this, could you please give me some advises? Thank you:)
image

@hbb1
Copy link
Owner

hbb1 commented May 10, 2024

Hi, we currently don't support non-ideal pinhole camera yet. Since we use a different projection method, modifying the projection matrix just doesn't work for 2DGS. To support this, we need to modify the rasterizer to support non-center intrinsic here https://github.com/hbb1/diff-surfel-rasterization/blob/main/cuda_rasterizer/forward.cu#L208. You can refer to this issue for making your data center.

@hbb1 hbb1 added the enhancement New feature or request label May 10, 2024
@hot-dog
Copy link
Author

hot-dog commented May 10, 2024

Hi, we currently don't support non-ideal pinhole camera yet. Since we use a different projection method, modifying the projection matrix just doesn't work for 2DGS. To support this, we need to modify the rasterizer to support non-center intrinsic here https://github.com/hbb1/diff-surfel-rasterization/blob/main/cuda_rasterizer/forward.cu#L208. You can refer to this issue for making your data center.

Thanks for you reply, i get it, i will modify the rasterizer code and try again.

@hbb1
Copy link
Owner

hbb1 commented May 13, 2024

Hi, can you check this PR #27 to see if the current implementation works for you?

BTW, make sure you recompile the latest rasterizer.

@hot-dog
Copy link
Author

hot-dog commented May 15, 2024

Sorry for the late reply, i modified the reaterizer code to adapt to principal point offset and the training can converge.

@hot-dog hot-dog closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants