Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data-test attribute mandatory #324

Open
Sodik opened this issue Jun 22, 2021 · 1 comment
Open

Make data-test attribute mandatory #324

Sodik opened this issue Jun 22, 2021 · 1 comment

Comments

@Sodik
Copy link
Collaborator

Sodik commented Jun 22, 2021

Not all components have data-test attribute. It breaks existing e2e and blocks creating new reliable test cases

@utkukaratas
Copy link
Contributor

what's worse is css-modules name mangling does make it very hard to deal with the components.

for example to get the text of a button you need selectors like this: $("[data-test='user-menu-button-trigger'] div[class*='__truncatedText'] span").text()

can't think of a simple solution :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants