Skip to content

Conversation

RobHam99
Copy link
Contributor

@RobHam99 RobHam99 commented Aug 4, 2021

Added aggregators for: count, double average, double sum, number average, fixed point sum, floating point sum, max, min, integer average, integer sum, long average and long sum. Also updated documentation with example of aggregator use.

@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Contributor

devOpsHazelcast commented Aug 4, 2021

CLA assistant check
All committers have signed the CLA.

@mdumandag
Copy link
Contributor

verify

@codecov-commenter
Copy link

Codecov Report

Merging #442 (0bd0fa1) into master (7d796f2) will decrease coverage by 0.14%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   86.62%   86.47%   -0.15%     
==========================================
  Files         336      340       +4     
  Lines       17398    17579     +181     
==========================================
+ Hits        15071    15202     +131     
- Misses       2327     2377      +50     
Impacted Files Coverage Δ
...st/protocol/codec/count_down_latch__await_codec.py 61.90% <61.90%> (ø)
hazelcast/proxy/map.py 73.32% <90.00%> (-0.06%) ⬇️
hazelcast/aggregator.py 97.39% <97.39%> (ø)
hazelcast/protocol/codec/map_aggregate_codec.py 100.00% <100.00%> (ø)
...otocol/codec/map_aggregate_with_predicate_codec.py 100.00% <100.00%> (ø)
hazelcast/reactor.py 77.51% <0.00%> (-6.70%) ⬇️
hazelcast/listener.py 68.60% <0.00%> (-1.17%) ⬇️
hazelcast/invocation.py 80.52% <0.00%> (-0.75%) ⬇️
hazelcast/connection.py 82.35% <0.00%> (-0.57%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d796f2...0bd0fa1. Read the comment docs.

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @RobHam99, the PR looks really great!
I left generally documentation-related comments.
Can you also add a code sample for it? Similar to this one https://github.com/hazelcast/hazelcast-nodejs-client/blob/master/code_samples/aggregation.js.

You can take a look at other code samples at this repo to see the structure we use

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort and patience @RobHam99. Working with you was a really smooth experience.
Let me run the tests again and after that merge the PR, if everything is okay

@mdumandag
Copy link
Contributor

verify

@mdumandag mdumandag merged commit 8de9c36 into hazelcast:master Aug 5, 2021
@mdumandag mdumandag mentioned this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants