-
Notifications
You must be signed in to change notification settings - Fork 74
Fast Aggregations #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast Aggregations #442
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
verify |
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
- Coverage 86.62% 86.47% -0.15%
==========================================
Files 336 340 +4
Lines 17398 17579 +181
==========================================
+ Hits 15071 15202 +131
- Misses 2327 2377 +50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats @RobHam99, the PR looks really great!
I left generally documentation-related comments.
Can you also add a code sample for it? Similar to this one https://github.com/hazelcast/hazelcast-nodejs-client/blob/master/code_samples/aggregation.js.
You can take a look at other code samples at this repo to see the structure we use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your effort and patience @RobHam99. Working with you was a really smooth experience.
Let me run the tests again and after that merge the PR, if everything is okay
verify |
Added aggregators for: count, double average, double sum, number average, fixed point sum, floating point sum, max, min, integer average, integer sum, long average and long sum. Also updated documentation with example of aggregator use.