Skip to content

Commit cd83ee2

Browse files
committed
address review comments
1 parent efec85e commit cd83ee2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/using_python_client_with_hazelcast_imdg.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1672,7 +1672,7 @@ it:
16721672
);
16731673
"""
16741674
1675-
client.sql.execute(mapping_query).result():
1675+
client.sql.execute(mapping_query).result()
16761676
16771677
employees.set(1, HazelcastJsonValue({"name": "John Doe", "salary": 60000}))
16781678
employees.set(2, HazelcastJsonValue({"name": "Jane Doe", "salary": 80000}))

hazelcast/sql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class SqlService(object):
6767
6868
client = hazelcast.HazelcastClient()
6969
70-
result = client.sql.execute("SELECT * FROM person")
70+
result = client.sql.execute("SELECT * FROM person").result()
7171
7272
for row in result:
7373
print(row.get_object("person_id"))
@@ -1142,7 +1142,7 @@ def _is_closed(execute_response):
11421142
otherwise.
11431143
"""
11441144
return (
1145-
execute_response.row_page is None # Just an update count
1145+
execute_response.row_metadata is None # Just an update count
11461146
or execute_response.row_page.is_last # Single page result
11471147
)
11481148

0 commit comments

Comments
 (0)