address review comments

Author: mdumandag

hazelcast/serialization/compact.py

@@ -1559,11 +1559,10 @@ def _raise_on_none_value_in_fix_sized_item_array(field: "FieldDescriptor") -> ty
 class SchemaWriter(CompactWriter):
     def __init__(self, type_name: str):
         self._type_name = type_name
-        self._fields: typing.List[FieldDescriptor] = []
-        self._field_names: typing.Set[str] = set()
+        self._fields: typing.Dict[str, FieldDescriptor] = {}
 
     def build(self) -> "Schema":
-        return Schema(self._type_name, self._fields)
+        return Schema(self._type_name, list(self._fields.values()))
 
     def write_boolean(self, field_name: str, value: bool) -> None:
         self._add_field(field_name, FieldKind.BOOLEAN)
@@ -1740,11 +1739,10 @@ def write_array_of_compact(
         self._add_field(field_name, FieldKind.ARRAY_OF_COMPACT)
 
     def _add_field(self, name: str, kind: "FieldKind"):
-        if name in self._field_names:
+        if name in self._fields:
             raise HazelcastSerializationError(f"Field with the name '{name}' already exists")
 
-        self._field_names.add(name)
-        self._fields.append(FieldDescriptor(name, kind))
+        self._fields[name] = FieldDescriptor(name, kind)
 
 
 class Schema:

hazelcast/serialization/service.py

@@ -7,7 +7,7 @@
 import typing
 
 from hazelcast.config import IntType, Config
-from hazelcast.errors import HazelcastInstanceNotActiveError
+from hazelcast.errors import HazelcastInstanceNotActiveError, IllegalArgumentError
 from hazelcast.serialization.api import IdentifiedDataSerializable, Portable
 from hazelcast.serialization.compact import (
     SchemaNotFoundError,
@@ -511,7 +511,7 @@ def validate(self):
         """
         for compact_type in self._compact_types:
             if compact_type in self._constant_type_dict:
-                raise HazelcastSerializationError(
+                raise IllegalArgumentError(
                     f"Compact serializer for the class {compact_type}' can not be "
                     f"registered as it overrides the default serializer for that "
                     f"class provided by Hazelcast."