Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI 3 support #56

Open
dotMorten opened this issue Dec 14, 2020 · 5 comments
Open

WinUI 3 support #56

dotMorten opened this issue Dec 14, 2020 · 5 comments

Comments

@dotMorten
Copy link

Do you have any plans on adding a WinUI 3 version of this awesome library? (and let me know if you'd need help)

@dotMorten
Copy link
Author

Just realized there's a PR here: #32

@hawkerm
Copy link
Owner

hawkerm commented Dec 16, 2020

Hey @dotMorten, yeah it's on the radar. Alex has just been playing with it for testing in the Windows Community Toolkit sample app as he tests out various toolkit things for WinUI 3 in general.

I need to merge in all the Uno Fork and update the NuGet package. I plan to try and refactor the base Monaco interface bits to pure .NET Standard library and investigate having a better separation of the WebView like Uno folks did not just for WASM, but for WebView vs. WebView2 as well. Ideally we could test this via WPF, WinUI 3, and Blazor? as well to try and consolidate efforts...

That's the grand plan at least... I just need to set aside some time over the holidays to dig into it a bit. I've side-lined myself mostly to my day job this year (for better and for worse)... Good news is I plan to have these priorities merge a bit more closely together (for this project at least) in 2021.

@hez2010
Copy link
Contributor

hez2010 commented Mar 3, 2021

Blocking issue: microsoft/microsoft-ui-xaml#4377

@hawkerm
Copy link
Owner

hawkerm commented Mar 12, 2021

@azchohfi in your latest update to #32, I'm assuming you didn't try the workaround yet from microsoft/microsoft-ui-xaml#4377 (comment) to enable AddHostObjectToScript directly and remove the custom code, eh? (Feels like a simple extension we could write and have to make it more source compatible?)

I can maybe try investigating this more next week too? 😊

@azchohfi
Copy link

That is not out yet. I double checked. It will be out on 0.5.0, but its not out on the prerelease one.

@hawkerm hawkerm mentioned this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants