Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Chart Username and Password are not working #190

Open
clemenko opened this issue Feb 22, 2024 · 6 comments
Open

[BUG] Chart Username and Password are not working #190

clemenko opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work
Milestone

Comments

@clemenko
Copy link
Contributor

clemenko commented Feb 22, 2024

Environmental Info:
67 degrees and overcast

Hauler Version:
1.0.0.0.0.0.0

System CPU architecture, OS, and Version:

Describe the bug:
the hauler store sync does not accept --username and --password fields for helm charts.

Steps To Reproduce:

apiVersion: content.hauler.cattle.io/v1alpha1
kind: Charts
metadata:
  name: rancher-charts
spec:
  charts:
    - name: rancher
      repoURL: https://releases.rancher.com/server-charts/latest
      version: v2.8.2
      username: bob
      password: denver

Expected behavior:
it work?

Actual behavior:
it not work

Additional context / logs:
kitten photo
1440

@amartin120
Copy link
Contributor

Temp solution would be to do a helm registry login [host] [flags] prior to running the hauler commands. Similar to what we were doing with cosign/docker login prior to adding hauler login for images.

I may look into splitting hauler login to handle either types as I'm not sure if I want people adding a bunch of username/passwords in their manifest.

@wcrum
Copy link
Contributor

wcrum commented Feb 23, 2024

@amartin120 related to authentication, what are your thoughts on extending the hauler store serve command with basic authentication and the ability to define TLS certs to serve via HTTPS? I know of several instances where HTTP in air-gapped / classified domains is strictly denied.

@clemenko
Copy link
Contributor Author

Temp solution would be to do a helm registry login [host] [flags] prior to running the hauler commands. Similar to what we were doing with cosign/docker login prior to adding hauler login for images.

I may look into splitting hauler login to handle either types as I'm not sure if I want people adding a bunch of username/passwords in their manifest.

this is the work around.
hauler store add chart chart1 --repo https://gitlab.com/......helm/stable --username="fsfsafdasfsdaf" --password="dsfsafsafs" --version 0.30.4

FYI helm registry login does not work...

@amartin120
Copy link
Contributor

amartin120 commented Feb 27, 2024

Hmm, helm registry login was working fine for me but I guess I'm going crazy(er). I'll need to dig into that as well.

Yeah, I'm just wrong on this one. Thanks for helping me think this through more. And just to reiterate your point, the hauler store add chart works fine. There just isn't a current solution for helm authentication when using the manifests.

@dweomer
Copy link
Contributor

dweomer commented Feb 27, 2024

As per convo with @amartin120, we need to implement hauler login for helm repositories that in effect does a helm repo add [--username=] [--password=]

@zackbradys zackbradys added bug Something isn't working enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work labels Mar 10, 2024
@zackbradys zackbradys added this to the Hauler v1.0.5 milestone Jun 26, 2024
@zackbradys
Copy link
Member

Hey @amartin120, please review this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work
Projects
Status: Work In Progress
Development

No branches or pull requests

5 participants