Skip to content
This repository was archived by the owner on Mar 16, 2025. It is now read-only.

Commit d35fede

Browse files
committed
Use privates
1 parent eb28fa1 commit d35fede

4 files changed

Lines changed: 24 additions & 17 deletions

File tree

src/http/request/form-decoding.capability.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,11 @@ class FormDecodingCapability<TInput extends HttpMeans, TBody>
5555
extends RequestCapability<TInput, RequestBodyMeans<TBody>>
5656
implements FormDecoding<TInput, TBody> {
5757

58-
constructor(
59-
private readonly _transform: RequestValueTransformer<TInput, URLSearchParams, TBody>,
60-
) {
58+
readonly #transform: RequestValueTransformer<TInput, URLSearchParams, TBody>;
59+
60+
constructor(transform: RequestValueTransformer<TInput, URLSearchParams, TBody>) {
6161
super();
62+
this.#transform = transform;
6263
}
6364

6465
for<TMeans extends TInput>(
@@ -79,7 +80,7 @@ class FormDecodingCapability<TInput extends HttpMeans, TBody>
7980
return context.next(
8081
handler,
8182
requestExtension<TMeans, RequestBodyMeans<TBody>>({
82-
requestBody: await this._transform(params, context as RequestContext<TInput>),
83+
requestBody: await this.#transform(params, context as RequestContext<TInput>),
8384
}),
8485
);
8586
};

src/http/request/http-forwarding.capability.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,16 @@ export interface HttpForwarding extends RequestCapability<HttpMeans> {
2828
*/
2929
class HttpForwardingCapability extends RequestCapability<HttpMeans> implements HttpForwarding {
3030

31-
constructor(private readonly _trust: HttpForwardTrust) {
31+
readonly #trust: HttpForwardTrust;
32+
33+
constructor(trust: HttpForwardTrust) {
3234
super();
35+
this.#trust = trust;
3336
}
3437

3538
for<TMeans extends HttpMeans>(handler: RequestHandler<TMeans & object>): RequestHandler<TMeans> {
3639
return ({ request, next }) => {
37-
const addresses = lazyValue(() => HttpAddressRep.by(request, this._trust));
40+
const addresses = lazyValue(() => HttpAddressRep.by(request, this.#trust));
3841

3942
return next(
4043
handler,

src/http/request/json-parsing.capability.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,11 @@ class JsonParsingCapability<TInput extends HttpMeans, TBody>
5757
extends RequestCapability<TInput, RequestBodyMeans<TBody>>
5858
implements JsonParsing<TInput, TBody> {
5959

60-
constructor(private readonly _transform: RequestValueTransformer<TInput, any, TBody>) {
60+
readonly #transform: RequestValueTransformer<TInput, any, TBody>;
61+
62+
constructor(transform: RequestValueTransformer<TInput, any, TBody>) {
6163
super();
64+
this.#transform = transform;
6265
}
6366

6467
for<TMeans extends TInput>(
@@ -84,7 +87,7 @@ class JsonParsingCapability<TInput extends HttpMeans, TBody>
8487
return next(
8588
handler,
8689
requestExtension<TMeans, RequestBodyMeans<TBody>>({
87-
requestBody: await this._transform(json, context as RequestContext<TInput>),
90+
requestBody: await this.#transform(json, context as RequestContext<TInput>),
8891
}),
8992
);
9093
};

src/testing/test-http-server.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,35 +24,35 @@ export class TestHttpServer {
2424
* @returns A promise resolved to started server.
2525
*/
2626
static start(): Promise<TestHttpServer> {
27-
return new TestHttpServer()._start();
27+
return new TestHttpServer().#start();
2828
}
2929

3030
/**
3131
* @internal
3232
*/
33-
private _listener: RequestListener;
33+
#listener: RequestListener;
3434

3535
/**
3636
* @internal
3737
*/
38-
private _server!: Server;
38+
#server!: Server;
3939

4040
private constructor() {
41-
this._listener = noop;
41+
this.#listener = noop;
4242
}
4343

4444
/**
4545
* HTTP server instance.
4646
*/
4747
get server(): Server {
48-
return this._server;
48+
return this.#server;
4949
}
5050

5151
/**
5252
* An address the service is bound to.
5353
*/
5454
get address(): AddressInfo {
55-
return this._server.address() as AddressInfo;
55+
return this.#server.address() as AddressInfo;
5656
}
5757

5858
/**
@@ -63,7 +63,7 @@ export class TestHttpServer {
6363
* @returns `this` instance.
6464
*/
6565
listenBy(listener: RequestListener): this {
66-
this._listener = listener;
66+
this.#listener = listener;
6767

6868
return this;
6969
}
@@ -113,9 +113,9 @@ export class TestHttpServer {
113113
/**
114114
* @internal
115115
*/
116-
private _start(): Promise<TestHttpServer> {
116+
#start(): Promise<TestHttpServer> {
117117
return new Promise((resolve, reject) => {
118-
const server = (this._server = createServer((request, response) => this._listener(request, response)));
118+
const server = (this.#server = createServer((request, response) => this.#listener(request, response)));
119119

120120
server.on('error', reject);
121121
server.on('listening', () => resolve(this));

0 commit comments

Comments
 (0)