Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated functions #11

Open
hats-bug-reporter bot opened this issue Nov 6, 2023 · 0 comments
Open

Use of deprecated functions #11

hats-bug-reporter bot opened this issue Nov 6, 2023 · 0 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@hats-bug-reporter
Copy link

Github username: --
Submission hash (on-chain): 0x1e594f92fde0c1e75fa6282565f3fbe46d7ec1988b7a969ea38a8d9be1a913c3
Severity: low

Description:
Attack Scenario

IncreaseAllowance and decreaseAllowance methods have been removed form @OpenZeppelin's implementation of ERC20.

OpenZeppelin/openzeppelin-contracts#4585

These functions are not part of the EIP-20 specs.

Attachments

Use safeIncreaseAllowance & safeDecreaseAllowance, it uses forceApproval. It's better to use non-depreciated standards to not affect future development.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/60e3ffe6a3cc38ab94cae995bc1de081eed79335/contracts/token/ERC20/utils/SafeERC20.sol#L48-L69
@hats-bug-reporter hats-bug-reporter bot added the bug Something isn't working label Nov 6, 2023
@bunbuntigery bunbuntigery added the wontfix This will not be worked on label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bunbuntigery