Add tud_midi_n_tx_avaiable interface created for easier flow control#3659
Open
SukuWc wants to merge 2 commits into
Open
Add tud_midi_n_tx_avaiable interface created for easier flow control#3659SukuWc wants to merge 2 commits into
SukuWc wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds public “available” query APIs to the USB MIDI device class so applications can implement flow control (notably when using non-peekable FIFOs) by checking TX/RX capacity before writing/reading.
Changes:
- Add new multi-interface APIs
tud_midi_n_tx_available()andtud_midi_n_rx_available(). - Add single-interface inline wrappers
tud_midi_tx_available()/tud_midi_rx_available()for interface 0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/class/midi/midi_device.h |
Declares new public availability APIs and adds single-interface inline wrappers. |
src/class/midi/midi_device.c |
Implements new availability APIs using endpoint-stream availability helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+297
to
+301
| uint32_t tud_midi_n_tx_available(uint8_t itf) { | ||
| midid_interface_t *p_midi = &_midid_itf[itf]; | ||
| tu_edpt_stream_t *ep_str = &p_midi->ep_stream.tx; | ||
| return tu_edpt_stream_write_available(p_midi->rhport, ep_str); | ||
| } |
Comment on lines
+303
to
+307
| uint32_t tud_midi_n_rx_available(uint8_t itf) { | ||
| midid_interface_t *p_midi = &_midid_itf[itf]; | ||
| tu_edpt_stream_t *ep_str = &p_midi->ep_stream.rx; | ||
| return tu_edpt_stream_read_available(ep_str); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added publicly accessible Tx and Rx available functions to the MIDI class driver. this allow proper flow-control to prevent data loss when using non-peekable tx FIFOs in the application.
Files changed
New interfaces
New inline functions