False success message during v1 -> v2 upgrade

[zee-hussain]

Version Information

Server Version: 1.3.2 -> 2.0.9
CLI Version (for CLI related issue): 2.0.9

Environment

OSS

What is the expected behaviour?

Hasura should output errors or issues when they occur during migrations and metadata application

What is the current behaviour?

Hasura cli-migrations-v3 image incorrectly stated that metadata was applied and reloaded successfully, when in reality the sql statements hit statement timeout and did not complete.

How to reproduce the issue?

1. Run v2.0.9 cli-migrations-v3 image against a db that contains hasura 1.3.2 metadata, set the statement timeout low and see if it logs an error when it reaches statement timeout

Screenshots or Screencast

cli-migrations-v3 image logs:

Note the "error" logs shown above are benign requests similar to the ones in this issue #3734

Postgres Logs: