Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Rename ovverrides non-nullable and array markers for TypeReference #10455

Closed
abhi40308 opened this issue Jul 16, 2024 · 1 comment
Closed

LSP: Rename ovverrides non-nullable and array markers for TypeReference #10455

abhi40308 opened this issue Jul 16, 2024 · 1 comment
Labels
c/v3-lsp ddnbugbounty-2024 k/bug Something isn't working k/v3-bug Bug affecting Hasura v3 (DDN)

Comments

@abhi40308
Copy link
Member

Version Information

LSP version : 1.0.1

Steps to repro:

  1. Have an object type field which is non-nullable like so Int4!
  2. Rename the underlying type
  3. The rename will override the non-nullability marker and will rename the whole object.

Before rename:

Screenshot 2024-07-16 at 11 33 03 AM

After rename:
Screenshot 2024-07-16 at 11 33 29 AM
@abhi40308 abhi40308 added k/bug Something isn't working k/v3-bug Bug affecting Hasura v3 (DDN) c/v3-lsp ddnbugbounty-2024 labels Jul 16, 2024
@abhi40308
Copy link
Member Author

fixed with v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/v3-lsp ddnbugbounty-2024 k/bug Something isn't working k/v3-bug Bug affecting Hasura v3 (DDN)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhi40308