Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-administrator HA users to see Grocy #256

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Allow non-administrator HA users to see Grocy #256

merged 1 commit into from
Nov 29, 2021

Conversation

MattDahEpic
Copy link
Contributor

Proposed Changes

Adds panel_admin: false to config.yaml allow non-admin HA users to see/access Grocy.

This would allow non-admin users to see Grocy. I personally use a non-admin "Panel" user on my wall tablets to prevent housemates from accidentally breaking something when messing around and currently the Panel user cannot see or access Grocy without opening the port and going around Ingress. In the future if work is ever done to allow home assistant users to login directly to Grocy using the auth API, this would (I assume) be needed anyway.

Related Issues

A Home Assistant frontend issue recommends using panel_admin for this purpose.

@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Nov 29, 2021
@frenck
Copy link
Member

frenck commented Nov 29, 2021

Rebased PR onto the latest main branch to deal with the CI error.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MattDahEpic 👍

@frenck frenck merged commit 68439cf into hassio-addons:main Nov 29, 2021
@MattDahEpic MattDahEpic deleted the patch-1 branch November 29, 2021 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants