Add missing php8-iconv package #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grocy now checks for iconv php module: grocy/grocy@a82ab47
frenck
force-pushed
the
patch-add-iconv
branch
from
df89da2 to
ddd6553
Compare
|
Rebased the PR onto the latest |
frenck
added
the
bugfix
frenck
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Grocy now requires iconv php module (among others already in the addon).
This PR adds the missing php8-iconv package installation in the Dockerfile.
Related Issues
Grocy PR introducing the check: grocy/grocy#1540