Skip to content

Patch error on startup #270

Closed
Closed
@blue-hound

Description

@blue-hound

Problem/Motivation

Patch /patches/fix_braindamage.patch is not correctly applied on startup. An error is generated in the startup log.

Expected behavior

Patch should be applied to default.blade.php

Actual behavior

[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing...
[cont-init.d] 01-log-level.sh: exited 0.
[cont-init.d] grocy.sh: executing...
[15:14:08] INFO: Patching Grocy to fix relative URL handling...
patching file views/layout/default.blade.php
patch unexpectedly ends in middle of line
patch: **** malformed patch at line 15:
[cont-init.d] grocy.sh: exited 0.

Steps to reproduce

I just have the default Grocy add-on installed and not modified. I have deleted the image and repulled from the command line with the 0.16.0 tag to ensure my files were correct. I have deleted the add-on and reinstalled. Same result.

Proposed changes

If I change +88,10 to +88,11 the patch is applied with a notice of an unexpected end. If I add a newline to the end of the last line of the patch, there are no errors present during the patch.

The minor, missing newline is highlighted here along with the 11 lines in the patch.

7cc3aa3?diff=split

Thanks for the great work! I don't think I caused this problem :-)

Quick edit to add that I have also used wget to get the tagged 0.16.0 file from Github with the same result.

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleThere has not been activity on this issue or PR for quite some time.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions