Add PosixFilePath and friends support (for AFPP) by hasufell · Pull Request #202 · haskell/unix

hasufell · 2022-03-22T20:48:43Z

For testing simple file operations, you can use https://github.com/hasufell/file-io (also please review the posix module)

@Bodigrim

hasufell · 2022-03-22T20:53:04Z

+source-repository-package
+    type: git
+    location: https://github.com/hasufell/filepath.git
+    tag: babf4068bd7e3c84b87033ed12542a34efa6a462


Bodigrim · 2022-04-17T18:49:13Z

@hasufell could you please rebase?

hasufell · 2022-05-01T07:59:48Z

ping

hs-viktor

Looks fine with minor nits. Please address those you don't object to, and rebase...

Bodigrim · 2022-06-02T19:45:02Z

@hasufell could you please rebase?

hasufell · 2022-06-02T20:29:10Z

@hasufell could you please rebase?

done

vdukhovni · 2022-06-02T20:49:07Z

Now that we have CI for "wasm", it is no longer in the way of routine work by wasm-agnostic maintainers. :-(
What's to be done about this? Can the wasm CI be enabled only on wasm branches? Or otherwise not get in the way?

Bodigrim · 2022-06-02T20:52:03Z

I’m AFK, but either Wasm CI job should honor settings in cabal.project, or filepath released officially. @vdukhovni are you happy with this branch otherwise?

hs-viktor · 2022-06-03T04:12:03Z

The ARM CI isn't working yet, and I should look a bit more carefully at the new Posix-flavoured Terminal.hsc.

Bodigrim · 2022-07-10T20:01:51Z

@TerrorJack ci-wasm32-wasi job does not seem to work any longer. Could you please take a look?

TerrorJack · 2022-07-11T06:13:38Z

Sure I'll open a PR against master to fix the job.

TerrorJack · 2022-07-11T08:20:19Z

@Bodigrim It should work now if you restart the job; I looked into it, and it seems to be a transient network failure; I added retry logic to the curl scripts.

hasufell · 2022-07-11T10:49:47Z

Not due to a network failure: https://github.com/haskell/unix/runs/7280567595?check_suite_focus=true

I don't know what wasm32-wasi-cabal, but it clearly is not the same as cabal. Why do we have this even?

TerrorJack · 2022-07-11T10:52:14Z

It's now a cabal bound issue, since ghc-wasm32-wasi uses a ghc-head build. I'm looking into relaxing bounds in the wasm32 cabal.project file atm.

hasufell · 2022-07-11T10:52:51Z

We might have been hit by https://gitlab.haskell.org/ghc/ghc/-/issues/21738

TerrorJack · 2022-07-11T10:56:43Z

@hasufell Thanks for the pointer! Given filepath is vendored in template-haskell in latest head which should resolve this issue, I'll proceed to update ghc-wasm32-wasi to latest head to unblock CI, but that'll take a couple more hours, are you fine with this timeframe?

TerrorJack · 2022-07-11T10:59:48Z

To provide more context, the job is to added to test unix support for wasm32-wasi platform, upcoming in 9.6, with more details in https://gitlab.haskell.org/ghc/ghc/-/wikis/WebAssembly-backend

hasufell · 2022-07-11T11:01:27Z

@hasufell Thanks for the pointer! Given filepath is vendored in template-haskell in latest head which should resolve this issue, I'll proceed to update ghc-wasm32-wasi to latest head to unblock CI, but that'll take a couple more hours, are you fine with this timeframe?

Yes

TerrorJack · 2022-07-11T22:39:58Z

If you push the fix at https://gist.github.com/TerrorJack/6352f35dc53e7b1b1baef4391ff86c3d, the ci-wasm32-wasi job should have been fixed now.

hs-viktor

LGTM. Modulo a pending rebase and ideally a successful CI run.

hasufell · 2022-07-16T22:27:35Z

+
+import System.Posix.Types
+import System.Posix.IO.Common
+import System.Posix.IO.ByteString ( fdRead, fdWrite )


We import fdRead and fdWrite from ByteString now.

Bodigrim · 2022-07-16T23:06:28Z

@hasufell there are several redundant imports. GHC build will choke on warnings.

Bodigrim

Thanks, great!

hasufell mentioned this pull request Mar 22, 2022

AFPP haskell/filepath#103

Merged

9 tasks

hasufell commented Mar 22, 2022

View reviewed changes

hasufell marked this pull request as draft March 22, 2022 20:54

hasufell force-pushed the AFPP branch from f37227e to 0d1115d Compare March 22, 2022 21:04

hasufell marked this pull request as ready for review March 22, 2022 21:04

hasufell force-pushed the AFPP branch 4 times, most recently from b7f1a64 to 2a96025 Compare March 24, 2022 19:44

hasufell mentioned this pull request Apr 15, 2022

AbstractFilePath support kowainik/relude#401

Open

Bodigrim reviewed Apr 17, 2022

View reviewed changes

Comment thread unix.cabal Outdated

hasufell force-pushed the AFPP branch 2 times, most recently from c98b694 to 4d7bce9 Compare May 1, 2022 07:48

hasufell force-pushed the AFPP branch 3 times, most recently from 76b3442 to c0fd56c Compare May 1, 2022 17:18

hasufell mentioned this pull request May 8, 2022

Add AFPP support haskell/directory#136

Merged

hs-viktor reviewed May 30, 2022

View reviewed changes

Comment thread System/Posix/IO/PosixString.hsc Outdated

Comment thread System/Posix/PosixString.hs

Comment thread cabal.project

hasufell mentioned this pull request Jun 1, 2022

bytestring parser pcapriotti/optparse-applicative#65

Closed

hasufell force-pushed the AFPP branch from c0fd56c to 7c17027 Compare June 2, 2022 20:29

hasufell force-pushed the AFPP branch 2 times, most recently from 567811d to c7c32da Compare June 2, 2022 20:58

hasufell force-pushed the AFPP branch from c7c32da to 11ae2d5 Compare June 18, 2022 22:10

hasufell force-pushed the AFPP branch from 2286a51 to f3b8ff8 Compare July 1, 2022 23:24

hasufell mentioned this pull request Jul 10, 2022

Release Planning: unix-2.8.0.0 (GHC 9.6.x) #164

Closed

5 tasks

hasufell added this to the 2.8.0.0 milestone Jul 10, 2022

hasufell force-pushed the AFPP branch from f3b8ff8 to 4433329 Compare July 11, 2022 10:34

TerrorJack mentioned this pull request Jul 11, 2022

Fix wasm CI / disable for PRs #226

Merged

hasufell force-pushed the AFPP branch 2 times, most recently from 8605076 to 2d86597 Compare July 12, 2022 17:29

hs-viktor approved these changes Jul 16, 2022

View reviewed changes

hasufell force-pushed the AFPP branch from 2d86597 to 4dfaa89 Compare July 16, 2022 22:26

hasufell commented Jul 16, 2022

View reviewed changes

hasufell force-pushed the AFPP branch from 4dfaa89 to 17570df Compare July 16, 2022 22:28

hasufell force-pushed the AFPP branch 2 times, most recently from be2f725 to 7f32a74 Compare July 16, 2022 23:14

hasufell added 2 commits July 17, 2022 02:27

Add PosixFilePath and friends support (for AFPP)

41e1843

Raise timeout

6037a37

hasufell force-pushed the AFPP branch from 7f32a74 to 6037a37 Compare July 17, 2022 00:27

Bodigrim approved these changes Jul 17, 2022

View reviewed changes

Bodigrim merged commit dd1f0aa into haskell:master Jul 17, 2022

hasufell mentioned this pull request Jul 21, 2022

Deprecate this package after unix-2.8.0.0 wrengr/unix-bytestring#17

Closed

Conversation

hasufell commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasufell Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

Bodigrim commented Apr 17, 2022

Uh oh!

Uh oh!

hasufell commented May 1, 2022

Uh oh!

hs-viktor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bodigrim commented Jun 2, 2022

Uh oh!

hasufell commented Jun 2, 2022

Uh oh!

vdukhovni commented Jun 2, 2022

Uh oh!

Bodigrim commented Jun 2, 2022

Uh oh!

hs-viktor commented Jun 3, 2022

Uh oh!

Bodigrim commented Jul 10, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

hasufell commented Jul 11, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

hasufell commented Jul 11, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

hasufell commented Jul 11, 2022

Uh oh!

TerrorJack commented Jul 11, 2022

Uh oh!

hs-viktor left a comment

Choose a reason for hiding this comment

Uh oh!

hasufell Jul 16, 2022

Choose a reason for hiding this comment

Uh oh!

Bodigrim commented Jul 16, 2022

Uh oh!

Bodigrim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hasufell commented Mar 22, 2022 •

edited

Loading