GHCJS patches. #111
Closed
GHCJS patches. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
reviewed
May 14, 2018
| @@ -520,7 +520,7 @@ foreign import ccall unsafe "fchown" | |||
| -- Note: calls @ftruncate@. | |||
| setFdSize :: Fd -> FileOffset -> IO () | |||
| setFdSize (Fd fd) off = | |||
| throwErrnoIfMinus1_ "setFdSize" (c_ftruncate fd off) | |||
| throwErrnoIfMinus1_ "setFdSize" (c_ftruncate fd (fromIntegral off)) | |||
There was a problem hiding this comment.
why does this impedance mismatch occur? I'm reluctant to use a non-statically checked fromIntegral conversion which have been a common source of fileoffset overflow bugs... :-/
| @@ -316,7 +316,7 @@ mode2Int SeekFromEnd = (#const SEEK_END) | |||
| -- | May throw an exception if this is an invalid descriptor. | |||
| fdSeek :: Fd -> SeekMode -> FileOffset -> IO FileOffset | |||
| fdSeek (Fd fd) mode off = | |||
| throwErrnoIfMinus1 "fdSeek" (Base.c_lseek fd off (mode2Int mode)) | |||
| throwErrnoIfMinus1 "fdSeek" (fmap fromIntegral $ Base.c_lseek fd (fromIntegral off) (mode2Int mode)) | |||
| @@ -9,7 +10,12 @@ import Foreign | |||
| import Foreign.C | |||
| import System.Exit | |||
| import System.IO.Error | |||
|
|
|||
| #ifdef ghcjs_HOST_OS | |||
There was a problem hiding this comment.
This seems the wrong place to kludge this around; why can't ghcjs' GHC.Conc (Signal) be used/fixed?
| @@ -432,11 +432,10 @@ installHandler :: Signal | |||
| -> Maybe SignalSet -- ^ other signals to block | |||
| -> IO Handler -- ^ old handler | |||
|
|
|||
| #ifdef __PARALLEL_HASKELL__ | |||
| ##if defined(__PARALLEL_HASKELL__) | |||
There was a problem hiding this comment.
why is it necessarily to delay the macro expansion?
|
Closing as stalled and supposedly superseded by a more modern effort in #205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches from the GHCJS project.