Fix handling of invalid bytes in stream decoders #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different bug that I found while troubleshooting #525. When we have 4 bytes buffered and they are invalid (whether in UTF8, 16, or 32), we skip the first byte, but the following (fifth) byte was being discarded instead of added to the end of the buffer. Interestingly, this bug and #525 have been around since 0.3.
This includes the commit from #527 because the changes are next to each other so there would be a conflict to resolve anyway. Rebasing should remove it.