Various fixes for posix_spawn refactoring
#213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code should be dead but for apparently some gcc versions cannot see this.
It appears that some older versions of gcc (e.g. 6.3.0, used in Debian 9)
cannot see that
path = strtok_r(...);
initialises `path`. Surgically disable this warning.
bgamari
changed the title
posix_spawn refactoringposix_spawn refactoring
|
Awesome, thanks! Want me to make a release? |
|
Thanks @snoyberg! Let's hold off on the release just a tad longer; I've seen something in further testing that has me a bit concerned. |
|
A brief update: I am increasingly certain that the issue that I mentioned earlier is actually a (rather nasty) GHC bug (namely https://gitlab.haskell.org/ghc/ghc/-/issues/20137) but it would likely still be prudent to wait until we have a fix and verification before doing a release. I'm hopeful that we'll have a fix tomorrow.. |
|
Alright, at this point I have eliminated this patch as the source for any of the issues we have seen in |
|
Upload complete! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, the refactor in #208 had a few issues which my earlier testing hadn't uncovered:
posix_spawnpath didn't correctly handle the case where the platform does not supportPOSIX_SPAWN_SETPGROUP-Werrorbuild in some casesfork_exec'ssetup_std_handle_forkfailed to return a value in some casesconfigurescript failed to declare its dependency on<spawn.h>, causing it to fail to findposix_spawnin some casesfind_executable.c, breaking the-Werrorbuildposix_spawnimplementationI have fixed all of these and tested on Linux, Darwin, and FreeBSD.
Fixes #210.