Skip to content

WIP: Try to extend CI to 9.2.1 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

michaelpj
Copy link
Collaborator

No description provided.

Also delete bounds on components other than the main library component,
they don't do anything.
@michaelpj
Copy link
Collaborator Author

@michaelpj
Copy link
Collaborator Author

I've pulled out the bounds changes to another PR, but this won't work for a bit.

@Ailrun
Copy link
Member

Ailrun commented Dec 15, 2021

@michaelpj For constraint-extras, it looks like their HEAD already supports GHC 9.2, and just the actual release haven't been cut yet. (At least their CI works: https://github.com/obsidiansystems/constraints-extras/runs/4389445166?check_suite_focus=true)

@Bodigrim
Copy link
Contributor

Looking at this and similar tickets for HLS, it seems that dependent-map subtree (dependent-sum, constraints-extras, dependent-sum-template, th-extras) causes constant delays, is it? Could it be replaced with typerep-map? Or maybe roll out a hand-written implementation of a type, isomorphic to DMap SMethod?

@michaelpj
Copy link
Collaborator Author

Yes, I think that's a good suggestion. I'd wondered about doing that, but I don't currently have a handle on how it's used. I'll take a look at what you suggested.

@michaelpj
Copy link
Collaborator Author

Removing dependent-sum and friends isn't trivial. We use GEq in a few places apart from the dependent map in lsp, and while we could just depend on some to get GEq, I really wouldn't want to write the instances by hand (big datatypes!), which pushes us back into the arms of dependent-sum-template.

@michaelpj
Copy link
Collaborator Author

Okay, now I think it's worth having a look at whether we can indeed get rid of dependent-map. It seems that we use it "properly" in a way that can't be obviously replaced by typerep-map. So hand-rolling a simple alternative might be the way to go.

@jneira
Copy link
Member

jneira commented Dec 22, 2021

Okay, now I think it's worth having a look at whether we can indeed get rid of dependent-map. It seems that we use it "properly" in a way that can't be obviously replaced by typerep-map. So hand-rolling a simple alternative might be the way to go.

we could leverage changes in lsp? or hls ones are highly unrelated with?

@michaelpj
Copy link
Collaborator Author

I don't think I could get rid of the usage in lsp, or at least I don't understand it enough to say yet. So easier to replace the datastructure at the moment.

@michaelpj
Copy link
Collaborator Author

Done in #384

@michaelpj michaelpj closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants