Ensure directory exists before searching for a .cabal file #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you know that you can just force-push new commits to old pull request branch and it will update properly? You do not have to create new pull requests. I find it slightly easier to just push fixed commits. |
|
First time, no; second time, I accidentally deleted the commit and when I tried to force push the new commit it didn't register in the patch request to let me re-open it :s |
|
We should put this workflow on some kind of |
|
I'd like to test this, how do I trigger the case you are solving here? |
|
|
ivan-m
force-pushed
the
cabal-nonexistent-directories
branch
from
655aa2b to
f1930bd
Compare
If you have a Cabalised project in an existing directory "/path/to/project/" and you want to add a new module into an as-yet nonexistent directory "Foo", you still might want to be able to find the .cabal file for that project (e.g. to use fields from the .cabal file to populate a skeleton for the new module). This patch keeps stripping off directories from the end of the path until an existing directory is found (or the directory is found to be nonsensical).
gracjan
added a commit
that referenced
this pull request
Mar 17, 2015
Ensure directory exists before searching for a .cabal file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @gracjan in #506, this makes
haskell-cabal-find-filecheck that the provided directory actually exists before using it to search for a .cabal file.