Skip to content

Officially support only Emacs 24.3 and later #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2016
Merged

Conversation

fice-t
Copy link
Contributor

@fice-t fice-t commented Apr 9, 2016

Closes #1218

Perhaps this should be merged after a new stable release has been created. Then in the readme there can be a link to the stable release saying "This is the last version that sort-of supports 24.1/24.2".

@gracjan
Copy link
Contributor

gracjan commented Apr 9, 2016

Well, current master does not work with 24.2 so it would be a problem to claim it does.

@fice-t
Copy link
Contributor Author

fice-t commented Apr 9, 2016

I suppose so. I was thinking that there should be a recent stable release that does support 24.1/24.2. Perhaps you could edit an older tag to include that info?

Actually, it turns out that haskell-mode v13.18 also has the error I mentioned here in 24.1.

Turns out that it's because locate-dominating-file doesn't accept a predicate as its 2nd argument before 24.3. This also means that 13.18 doesn't fully support 24.1, 24.2, or even 23.
13.16 seems to be fine.

@gracjan
Copy link
Contributor

gracjan commented Apr 9, 2016

We can include this information in the manual. We have one paragraph about Emacs 23, we can have more.

@gracjan
Copy link
Contributor

gracjan commented Apr 9, 2016

So, can you:

  • add compatibility info in manual, there is a paragraph about this so next to it.
  • change all instances of (defvar x ...) (make-variable-buffer-local 'x) into defvar-local
  • change all instances of (set (make-local-variable ..) ..) into setq-local

?

This would clean up most glaring syntax problems.

@fice-t
Copy link
Contributor Author

fice-t commented Apr 9, 2016

What should it say? That 13.16 is the last version to support <24.3 or 13.18? As it stands 13.18 doesn't.

@gracjan
Copy link
Contributor

gracjan commented Apr 9, 2016

13.16

@fice-t
Copy link
Contributor Author

fice-t commented Apr 9, 2016

Now the manual just points to 13.16 as the latest version for 23/24.1/24.2 support.

The setq-local/defvar-local stuff was done with a query-replace-regex, but it should be fine.

Can now use these macros as support only goes back to 24.3.
@gracjan gracjan merged commit 40b1df7 into haskell:master Apr 10, 2016
@fice-t
Copy link
Contributor Author

fice-t commented Apr 12, 2016

@gracjan The release descriptions for 13.16 and 13.18 should probably get updated to match the manual.

@fice-t
Copy link
Contributor Author

fice-t commented Apr 20, 2016

@gracjan Ah, also, are there any plans for the NEWS file? It hasn't been updated for a while.

@gracjan
Copy link
Contributor

gracjan commented Apr 21, 2016

I don't have energy for that. If you want to fix it then there is 15 months of Haskell Mode reports as a source material.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants