Stylish-haskell runs on buffer instead of file on disk

[wraithm]

So, I made stylish-haskell run on the current buffer. Now, when there's an error, stderr gets dumped to the buffer at the top of the file... This is probably not ideal, but it's the best I could manage with call-process-region.

[wraithm]

Another way to possibly do this would be make a temporary file, save the current buffer to that temp file, then run stylish-haskell on that temp file with call-process (instead of call-process-region). You can get a separate stdout and stderr file with call-process, you can't get that with call-process-region.

[wraithm]

Yeah, this solution is a hack. I don't think we should go with this solution.

[gracjan]

Docs say:

(call-process-region START END PROGRAM &optional DELETE BUFFER DISPLAY
&rest ARGS)

Send text from START to END to a synchronous process running PROGRAM.
The remaining arguments are optional.
Delete the text if fourth arg DELETE is non-nil.

Insert output in BUFFER before point; t means current buffer; nil for
 BUFFER means discard it; 0 means discard and don't wait; and `(:file
 FILE)', where FILE is a file name string, means that it should be
 written to that file (if the file already exists it is overwritten).
BUFFER can also have the form (REAL-BUFFER STDERR-FILE); in that case,
REAL-BUFFER says what to do with standard output, as above,
while STDERR-FILE says what to do with standard error in the child.
STDERR-FILE may be nil (discard standard error output),
t (mix it with ordinary output), or a file name string.

Note that BUFFER may separate STDERR from STDOUT.

[wraithm]

I made a new PR where stdout and stderr are handled. #1268

[gracjan]

This temp buffer can be the same buffer as the one created with with-temp-buffer below, I think.

[gracjan]

Does look pretty close to good solution to me...

[gracjan]

I see. Do you know that in github you can just add commits to already open PR or even do a force push? No need to open new PRs :)