getLocatedImportsRule: "Simplify" some bogus logic #4759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ugh, now I get it. It really is only about the sharing. Seems like the cold I have is also affecting my brain function. :/ |
Member
Author
|
I wonder whether haskell-unordered-containers/unordered-containers#546 I would love to get your feedback on that idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR could have been an issue, but I wanted to use your CI to check whether my understanding of this code is correct.
ttmapis aHashMapthat maps eachNormalizedFilePathkey to itself.nfpis a member ofttmap, we find the samenfpin the map, and havenfp' = nfp.nfpisn't a member, we fall back to the default, which is alsonfp.nfp' = nfp.I don't actually know what this code was meant to do! It was introduced in 0e642b3.