Nix tooling (minor changes) #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hlint` should not be necessary. However, this is an opinion up for debate: We do not really need the `hlint` executable because it is integrated in HLS. However, `hlint` is used by a GitHub Action, which we may want to replicate locally. Also, the `fmt.sh` script is downloading an (unknown) `hlint` version which will not work on NixOS anyways. In my opinion, if `fmt.sh` is still used (I can not find any usages) we should fix the script so it is reproducible.
dschrempf
requested review from
berberman,
michaelpj and
guibou
as code owners
fendor
approved these changes
Feb 9, 2025
|
I am surprised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR contains a few minor changes to the Nix Flake.
b473c73 * Nix: Update lock files (GHC 9.6.5 -> 9.6.6)
a1b5c43 * Nix Flake: Small fixes, make comments a bit more consistent
39df624 * Nix Flake: Remove
hlintI also removed
hlintfrom the flake (last commit). However, this is an opinion up for debate:We do not really need the
hlintexecutable because it is integrated in HLS.However,
hlintis used by a GitHub Action, which we may want to replicate locally.Also, the
fmt.shscript is downloading an (unknown)hlintversion which willnot work on NixOS anyways. In my opinion, if
fmt.shis still used (I can notfind any usages) we should fix the script so it is reproducible.