Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporting operator pattern synonym #4420

Merged

Conversation

pbrinkmeier
Copy link
Contributor

@pbrinkmeier pbrinkmeier commented Oct 11, 2024

This PR addresses #4379.

  • Adds a few tests for exporting pattern synonyms with operator names.
  • Parenthesizes any name to be exported if it starts with an operator character.

The last commit restructures the code such that any name is parenthesized regardless of what it is exported as.

@fendor fendor requested review from michaelpj and fendor October 11, 2024 12:20
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbrinkmeier
Copy link
Contributor Author

Not sure why the pre-commit check is failing :/

@fendor fendor merged commit da403a7 into haskell:master Oct 12, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants