Add Goto Definition for cabal common sections #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VenInf I think this PR is relevant to you as well and might be implementing some util functions you could benefit from as well. Could you review this PR? |
fendor
requested changes
Aug 4, 2024
Comment on lines
292
to
295
| case uriToFilePath' uri of | ||
| Nothing -> | ||
| pure $ InR $ InR Null | ||
| Just filePath -> do |
There was a problem hiding this comment.
Prefer getNormalizedFilePathE which takes care of the validation.
Suggested change
| case uriToFilePath' uri of | |
| Nothing -> | |
| pure $ InR $ InR Null | |
| Just filePath -> do | |
| nfp <- getNormalizedFilePathE uri |
Then use fromNormalizedFilePath if you need the underlying FilePath.
| @@ -1,12 +1,16 @@ | |||
| module Ide.Plugin.Cabal.Completion.CabalFields (findStanzaForColumn, findFieldSection, getOptionalSectionName, getAnnotation, getFieldName, onelineSectionArgs) where | |||
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} | |||
| module Ide.Plugin.Cabal.Completion.CabalFields (findStanzaForColumn, findFieldSection, findTextWord, findFieldLine, getOptionalSectionName, getAnnotation, getFieldName, onelineSectionArgs, getFieldEndPosition, getSectionArgEndPosition, getNameEndPosition, getFieldLineEndPosition, getFieldLSPRange) where | |||
There was a problem hiding this comment.
I am amazed stylish-haskell accepts this.
Would you mind introducing a couple of new lines to make this easier to read? E.g.
Suggested change
| module Ide.Plugin.Cabal.Completion.CabalFields (findStanzaForColumn, findFieldSection, findTextWord, findFieldLine, getOptionalSectionName, getAnnotation, getFieldName, onelineSectionArgs, getFieldEndPosition, getSectionArgEndPosition, getNameEndPosition, getFieldLineEndPosition, getFieldLSPRange) where | |
| module Ide.Plugin.Cabal.Completion.CabalFields | |
| ( findStanzaForColumn, | |
| findFieldSection, | |
| findTextWord, | |
| ... | |
| ) where |
or something like that?
| @@ -1,12 +1,16 @@ | |||
| module Ide.Plugin.Cabal.Completion.CabalFields (findStanzaForColumn, findFieldSection, getOptionalSectionName, getAnnotation, getFieldName, onelineSectionArgs) where | |||
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} | |||
There was a problem hiding this comment.
Suggested change
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} |
Looks unused?
| import Data.List.NonEmpty (NonEmpty) | ||
| import qualified Data.List.NonEmpty as NE | ||
| import qualified Data.Text as T | ||
| import qualified Data.Text.Encoding as T | ||
| import qualified Distribution.Fields as Syntax | ||
| import qualified Distribution.Parsec.Position as Syntax | ||
| import Ide.Plugin.Cabal.Completion.Types | ||
| import qualified Language.LSP.Protocol.Types as LSPTypes |
There was a problem hiding this comment.
Nitpick:
Suggested change
| import qualified Language.LSP.Protocol.Types as LSPTypes | |
| import qualified Language.LSP.Protocol.Types as LSP |
Other parts of the codebase use this qualified import. Perhaps we should have some kind of style guide? Hard to tell.
Comment on lines
78
to
80
| -- that are not a space or column. | ||
|
|
||
| -- This function currently only considers words inside of a @FieldLine@. |
There was a problem hiding this comment.
Suggested change
| -- that are not a space or column. | |
| -- This function currently only considers words inside of a @FieldLine@. | |
| -- that are not a space or column. | |
| -- | |
| -- This function currently only considers words inside of a @FieldLine@. |
Otherwise, the haddock comment will not be attached to the function :)
|
Thank you for your work! The only comment I might have, is that I thought about mimicking |
VeryMilkyJoe
requested changes
Aug 14, 2024
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/CabalFields.hs
Outdated
Show resolved
Hide resolved
VenInf
reviewed
Aug 14, 2024
4 tasks
ChristophHochrainer
force-pushed
the
feature/cabal/import-go-to-definition
branch
from
62972ef to
8f164e2
Compare
ChristophHochrainer
force-pushed
the
feature/cabal/import-go-to-definition
branch
from
8f164e2 to
c2d980c
Compare
ChristophHochrainer
force-pushed
the
feature/cabal/import-go-to-definition
branch
from
e35a426 to
d0d0f94
Compare
fendor
approved these changes
Aug 18, 2024
fendor
changed the title
VeryMilkyJoe
approved these changes
Aug 18, 2024
VenInf
pushed a commit
to VenInf/haskell-language-server
that referenced
this pull request
Aug 18, 2024
* Add goto-definitions for cabal common sections * Add default direct cradle hie.yaml file to testdata * incorporate changes requested in haskell#4375 * add tests for cabal goto-definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of a go to definition code action for cabal files.