Migrate FindDefinitionAndHoverTests and HighlightTests part of #4173 and fix HighlightTests #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
changed the title
soulomoon
changed the title
soulomoon
changed the title
31 tasks
michaelpj
approved these changes
May 2, 2024
|
This should be the relating issue for the highlight test |
soulomoon
changed the title
soulomoon
changed the title
|
I have added a small patch to filter out the evidence nodeids before carrying a seach for highlighting items. |
…ls-FindDefinitionAndHoverTests
fendor
approved these changes
May 2, 2024
michaelpj
reviewed
May 2, 2024
|
The fix seems plausible, but also I think there is still an underlying issue, right? So it would be nice to not forget about that. |
|
The root is the introducion of ghc generated nodes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.