Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic token omitting record field in {-# LANGUAGE DuplicateRecordFields #-} #3950 #3951

Merged

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Jan 13, 2024

fix omitting record field and {-# LANGUAGE DuplicateRecordFields #-}
and add test case for it

@soulomoon soulomoon changed the title fix: stop omit generated occname in semantic tokens query #3950 fix: Semantic token omitting record field in {-# LANGUAGE DuplicateRecordFields #-} #3950 Jan 13, 2024
@soulomoon soulomoon changed the title fix: Semantic token omitting record field in {-# LANGUAGE DuplicateRecordFields #-} #3950 fix: semantic token omitting record field in {-# LANGUAGE DuplicateRecordFields #-} #3950 Jan 13, 2024
@soulomoon soulomoon marked this pull request as ready for review January 13, 2024 22:27
@soulomoon soulomoon enabled auto-merge (squash) January 13, 2024 23:52
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failed before the change, I assume?

@soulomoon soulomoon merged commit b000b6b into master Jan 14, 2024
@soulomoon
Copy link
Collaborator Author

Yes, the I add a test that would fail if no change to current source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic token omitting record field in {-# LANGUAGE DuplicateRecordFields #-}
2 participants