Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable stan plugin by default #3917

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Disable stan plugin by default #3917

merged 1 commit into from
Dec 23, 2023

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Dec 21, 2023

Closes #3916

@fendor fendor requested a review from michaelpj December 21, 2023 17:42
@fendor fendor requested a review from 0rphee as a code owner December 21, 2023 17:42
@fendor
Copy link
Collaborator Author

fendor commented Dec 21, 2023 •
edited
Loading

Even with this change:

    "haskell.plugin.stan.globalOn": {
        "default": true,
        "description": "Enables stan plugin",
        "scope": "resource",
        "type": "boolean"
    }

What do I have to do to set the default to false? Seems to be a missing feature in the vscode-extension schema command.

@fendor fendor force-pushed the enhance/disable-stan-by-default branch 2 times, most recently from 377ebdc to b2a4f6d Compare December 22, 2023 09:34
@fendor fendor force-pushed the enhance/disable-stan-by-default branch from b2a4f6d to ac0903e Compare December 22, 2023 09:41
@michaelpj
Copy link
Collaborator

Yeah, generate-default-config seems to show it off by default, so I think you're right.

0rphee
0rphee approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@0rphee 0rphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. It works with my editor.

@michaelpj michaelpj merged commit 133dcdc into haskell:master Dec 23, 2023
soulomoon added a commit to soulomoon/haskell-language-server that referenced this pull request Dec 24, 2023
@soulomoon
Squashed commit of the following:
751f57f 
commit c9300f0
Author: Patrick <fwy996602672@gmail.com>
Date:   Sun Dec 24 11:37:42 2023 +0800

    fix description

commit 7bb851f
Author: Patrick <fwy996602672@gmail.com>
Date:   Sun Dec 24 11:36:29 2023 +0800

    fix descriptions

commit 1754992
Author: Patrick <fwy996602672@gmail.com>
Date:   Sun Dec 24 11:32:33 2023 +0800

    fix updatePositionMapping to use mapAccumWithKey

commit 77c7a8d
Merge: 640c421 133dcdc
Author: Patrick Wales <fwy996602672@gmail.com>
Date:   Sun Dec 24 08:40:00 2023 +0800

    Merge branch 'master' into FixStaleDataPositionMappings

commit 640c421
Author: Patrick <fwy996602672@gmail.com>
Date:   Sun Dec 24 08:18:08 2023 +0800

    fix updatePositionMapping using `addOldDelta` instead of `addDelta`

commit 133dcdc
Author: fendor <fendor@users.noreply.github.com>
Date:   Sat Dec 23 12:32:51 2023 +0100

    Disable stan plugin by default (haskell#3917)

commit e0764e5
Author: Patrick <fwy996602672@gmail.com>
Date:   Sat Dec 23 19:21:42 2023 +0800

    add export addOldDelta

commit 4256e7f
Author: Patrick <fwy996602672@gmail.com>
Date:   Sat Dec 23 19:08:51 2023 +0800

    Fix positionMapping in stale data
soulomoon pushed a commit to soulomoon/haskell-language-server that referenced this pull request Dec 25, 2023
@fendor @soulomoon
Disable stan plugin by default (haskell#3917)
22e7171
soulomoon pushed a commit to soulomoon/haskell-language-server that referenced this pull request Dec 27, 2023
@fendor @soulomoon
Disable stan plugin by default (haskell#3917)
0fe815e
@fendor fendor mentioned this pull request Jan 4, 2024
Merged
@michaelpj michaelpj mentioned this pull request Jan 5, 2024
Merged
23 tasks
michaelpj added a commit that referenced this pull request Jan 6, 2024
@soulomoon @fendor @michaelpj
Implement semantic tokens plugin to support semantic highlighting(tex…
37925a0 
…tDocument/semanticTokens/full) (#3892)

* Implement semantic tokens lsp plugin draft

* SemanticTokens: combine information extracted from HieAst

* clean up

* map to default token types in lsp

* use lsp makeSemanticTokens to convert to lsp SemanticTokens type

* add test and cleanup

* refine semantic type to default one in lsp

* Use tokens from hieAst instead of renamedSource and add test

* use customize RefMap to get semantic type

* use refMap from useAsts

* Also compute imported names

* Also compute semantic type from TyThing

* Fix dependencies version

* fix version

* Retrieve nameSet from renamedSource to prevent names not visible(Such as by instance deriving) being handled

* add hlint config to ignore test data

* cean up test data

* revert flake.nix

* Rename query.hs to Query.hs

* Build: add semantic tokens to lts21

* Refactor and add README

* Semantic token, filter names in Ast

* CI: add consistancy check for wether semantic tokens computations is stable across different ghc versions

* Update documentation, cleanup test, remove default modifiers

* Fix: IO now classfied to TTypcon, add test for GADT and data family, Update documentation

* Restore stack.yaml

* fix stack build

* Refactor, move out ActualToken to Mappings and use ide logger

* Refactor: toLspTokenType should return Maybe type

* Stop use stale hieAst

* add getImportedNameSemanticRule rule to semantic tokens plugin

* do not retrieve hie in getImportedNameSemanticRule

* fix: add description for semantic tokens

* remove TValBind and TPaternBind and Use TFunction and TVariable instead

* cleanup

* Refactor useWithStaleMT and took care of the token range using position map

* fix build for 9.4

* refactor, use golden test

* refactor, use ExceptT for computeSemanticTokens

* Fix 9.2

* add persistentSemanticMapRule to prevent semantic tokens block on startup

* Fix, use hieKind instead of cast the type directly

* add options to turn semantic tokens on and off

* Disable stan plugin by default (#3917)

* Fix positionMapping in stale data (#3920)

* Fix positionMapping in stale data

* add test for updatePositionMapping

* add comment to demonstrate addOldDelta

* cleanup

* fix: for local variable, extract type from contextInfo instead of bind site, thus function in pattern binds can also be indentified

* clean up

* Update plugins/hls-semantic-tokens-plugin/src/Ide/Plugin/SemanticTokens/Query.hs

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

* refactor: remove TNothing and compact the test output

* refactor: rename SemanticTokenType to HsSemanticTokenType to avoid confusion with lsp' SemanticTokenTypes

* refactor: push the computation of semantic token type to getSemanticTokensRule

* update documentation

* cleanup hieAstSpanNames

* remove renamed source from getSemanticTokensRule and optimize query function for semantic token type

* try to exclude names that is not visible in hie and cleanup

* add HieFunMaskKind, it is to differ wether a type at type index is a function or non-function

* expose function flag to expose (=>, ->, -=>, ==>)

* 1. Relax GetDocMap kindMap to get TyThing for more than type variables.
2. Backport isVisibleFunArg

* use customize logger, add test for unicode

* fix: handle unicode in semantic tokens

* update KindMap to TyThingMap

* cleanup

* add realSrcSpanToCodePointRange, realSrcLocToCodePointPosition to Development.IDE.GHC.Error

* add Note [Semantic information from Multiple Sources]

* move recoverFunMaskArray to Mappings.hs

* fix test, data.Set might not appear

* fix: handle semantic tokens with more than one ast

* fix: instance PluginMethod Request Method_TextDocumentSemanticTokensFull

* clean up

* turn semantic tokens off by default

* fix doc

* clean up doc

---------

Co-authored-by: fendor <fendor@users.noreply.github.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
@chenrui333 chenrui333 mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@0rphee 0rphee 0rphee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stan plugin (enabled by default) gives obnoxious suggestions
3 participants
@fendor @michaelpj @0rphee