Fix Show instance #2802
Merged
Fix Show instance #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Mar 29, 2022
| deriving newtype (Eq, Show, Typeable, Hashable, NFData) | ||
| deriving newtype (Eq, Typeable, Hashable, NFData) | ||
|
|
||
| instance Show GhcSessionDeps where |
There was a problem hiding this comment.
What's wrong with the derived one? Worth a comment.
There was a problem hiding this comment.
It prints True or False instead of the key name
There was a problem hiding this comment.
The problem is that the deriving strategy is new type instead of stock
There was a problem hiding this comment.
So why not use the stock deriving?
There was a problem hiding this comment.
Oh the stock instance is very verbose and bloats traces. I have changed the custom instance to not ignore the boolean for good measure.
pepeiborra
force-pushed
the
fix-show-instance
branch
from
8f7a97e to
a587e9a
Compare
pepeiborra
force-pushed
the
fix-show-instance
branch
from
a587e9a to
1621dee
Compare
wz1000
approved these changes
Apr 16, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.