Skip to content

Fix crash for non-LSP modes wrt #2627 #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fix crash for non-LSP modes wrt #2627 #2719

merged 2 commits into from
Feb 18, 2022

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Feb 18, 2022 •
edited by gitpod-io bot
Loading

@hasufell hasufell requested a review from pepeiborra as a code owner February 18, 2022 10:03
@hasufell hasufell mentioned this pull request Feb 18, 2022
Closed
@hasufell hasufell requested review from fendor and wz1000 February 18, 2022 10:08
fendor
fendor approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Feb 18, 2022
@mergify mergify bot merged commit 4018b68 into haskell:master Feb 18, 2022
@hasufell hasufell mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@fendor fendor fendor approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasufell @michaelpj @fendor