Avoid creating IsFileOfInterest keys for non workspace files

[pepeiborra]

There's no need to create IsFileOfInterest keys for every interface file

[ndmitchell]

In VS Code you can open individual files that aren't in the workspace. If you have goto definition, then often that is super easy. What happens then?

[pepeiborra]

In VS Code you can open individual files that aren't in the workspace. If you have goto definition, then often that is super easy. What happens then?

• The file is not in the workspace, so it doesn't get an IsFileOfInterest dependency
• The file will be VFS, so it gets an alwaysRerun dependency

Now the GetModificationTime for this file has an alwaysRerun dependency forever, i.e. it will never transition to the non alwaysRerun state. This is exactly what we want for non-workspace files, since they are not watched. So all is good.

[ndmitchell]

So it sounds like your argument is if we hit the alwaysRerun path than isFileOfInterest is not interesting. If so, why both with the isWorkspaceFile check? Why not move it down to the branches where alwaysRerun isn't hit, and save ourself the dependency in a more?

I note there are now two local definitions for isWF being whether the file is a workspace file, or a watched file. Would be good to use distinct names.

[pepeiborra]

So it sounds like your argument is if we hit the alwaysRerun path than isFileOfInterest is not interesting. If so, why both with the isWorkspaceFile check? Why not move it down to the branches where alwaysRerun isn't hit, and save ourself the dependency in a more?

Right, that's a good point. I'll move the IsFileOfInterest dependency down to the branch and remove the isWorkspaceFile check.

[ndmitchell]

Thanks - this code is now beautifully understandable - I learnt something about the old code from your rewrite :)