Skip to content

Use last with-utf8 to fix #1372 #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2021
Merged

Use last with-utf8 to fix #1372 #1399

merged 7 commits into from
Feb 19, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 18, 2021

Ailrun
Ailrun requested changes Feb 18, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, sorry for changing the review. We need to update stack.yaml too.

@jneira
Copy link
Member Author

jneira commented Feb 18, 2021 •
edited
Loading

thanks for noting it, i had to remove duplicate entries in 8.6 too 🤦

Ailrun
Ailrun approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Feb 18, 2021
@jneira
Copy link
Member Author

jneira commented Feb 19, 2021

silly changes, silly mistakes 😟

@mergify mergify bot merged commit 409ba80 into haskell:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Error for 8.10.4 (maybe only under Windows)
2 participants
@jneira @Ailrun