Remove outdated TODO items

Author: jian-lin

haskell-language-server.cabal

@@ -848,7 +848,6 @@ common signatureHelp
     build-depends: haskell-language-server:hls-signature-help-plugin
     cpp-options: -Dhls_signatureHelp
 
--- TODO(@linj) remove unneeded deps
 library hls-signature-help-plugin
   import:           defaults, pedantic, warnings
   if !flag(signatureHelp)

hls-plugin-api/src/Ide/Types.hs

@@ -770,7 +770,6 @@ instance PluginRequestMethod Method_TextDocumentDocumentSymbol where
             si = SymbolInformation name' (ds ^. L.kind) Nothing parent (ds ^. L.deprecated) loc
         in [si] <> children'
 
--- TODO(@linj) is this correct?
 instance PluginRequestMethod Method_TextDocumentSignatureHelp where
   combineResponses _ _ _ _ (x :| _) = x
 

plugins/hls-signature-help-plugin/src/Ide/Plugin/SignatureHelp.hs

@@ -72,11 +72,10 @@ import           Language.LSP.Protocol.Types          (MarkupContent (MarkupCont
                                                        UInt,
                                                        type (|?) (InL, InR))
 
-data Log = LogDummy
+data Log
 
 instance Pretty Log where
     pretty = \case
-        LogDummy -> "TODO(@linj) remove this dummy log"
 
 descriptor :: Recorder (WithPriority Log) -> PluginId -> PluginDescriptor IdeState
 descriptor _recorder pluginId =
@@ -88,7 +87,6 @@ signatureHelpProvider :: PluginMethodHandler IdeState Method_TextDocumentSignatu
 signatureHelpProvider ideState _pluginId (SignatureHelpParams (TextDocumentIdentifier uri) position _mProgreeToken mSignatureHelpContext) = do
     nfp <- getNormalizedFilePathE uri
     results <- runIdeActionE "signatureHelp.ast" (shakeExtras ideState) $ do
-        -- TODO(@linj) why HAR {hieAst} may have more than one AST?
         (HAR {hieAst, hieKind}, positionMapping) <- useWithStaleFastE GetHieAst nfp
         case fromCurrentPosition positionMapping position of
             Nothing -> pure []
@@ -112,7 +110,6 @@ signatureHelpProvider ideState _pluginId (SignatureHelpParams (TextDocumentIdent
         [(_functionName, [], _argumentNumber)] -> pure $ InR Null
         [(functionName, functionTypes, argumentNumber)] ->
             pure $ InL $ mkSignatureHelp mSignatureHelpContext docMap argDocMap (fromIntegral argumentNumber - 1) functionName functionTypes
-        -- TODO(@linj) what does non-singleton list mean?
         _ -> pure $ InR Null
 
 mkSignatureHelp :: Maybe SignatureHelpContext -> DocMap -> ArgDocMap -> UInt -> Name -> [Type] -> SignatureHelp
@@ -250,7 +247,6 @@ nodeHasAnnotation annotation hieAst = case sourceNodeInfo hieAst of
     Nothing       -> False
     Just nodeInfo -> isAnnotationInNodeInfo annotation nodeInfo
 
--- TODO(@linj): the left most node may not be the function node. example: (if True then f else g) x
 getLeftMostNode :: HieAST a -> HieAST a
 getLeftMostNode thisNode =
     case nodeChildren thisNode of
@@ -275,7 +271,7 @@ getNodeNameAndTypes hieKind hieAst =
                          in Just (name, filterCoreTypes allTypes)
             [] -> Nothing
             _ -> Nothing -- seems impossible
-        else Nothing -- TODO(@linj) must function node be HsVar?
+        else Nothing
     where
         extractName = rightToMaybe
 
@@ -291,7 +287,6 @@ getNodeNameAndTypes hieKind hieAst =
 isUse :: IdentifierDetails a -> Bool
 isUse = identInfo >>> S.member Use
 
--- TODO(@linj) handle more cases
 -- Just 1 means the first argument
 getArgumentNumber :: RealSrcSpan -> HieAST a -> Maybe Integer
 getArgumentNumber span hieAst

plugins/hls-signature-help-plugin/test/Main.hs

@@ -502,7 +502,7 @@ instance (IsSimilar a, IsSimilar b) => IsSimilar (a |? b) where
     InR x ~= InR y = x ~= y
     _ ~= _         = False
 
--- TODO(@linj) use the one from lsp-test when we have https://github.com/haskell/lsp/pull/621
+-- TODO use the one from lsp-test when we have https://github.com/haskell/lsp/pull/621
 -- | Returns the signature help at the specified position.
 getSignatureHelp :: TextDocumentIdentifier -> Position -> Session (Maybe SignatureHelp)
 getSignatureHelp doc pos =